Feature #15966

Include list of device-mapper devices in debug output

Added by segfault 2018-09-20 21:20:45 . Updated 2018-10-24 11:19:07 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Start date:
2018-09-20
Due date:
% Done:

100%

Feature Branch:
feature/15966-dm-and-loop-debug-output
Type of work:
Code
Blueprint:

Starter:
Affected tool:
WhisperBack
Deliverable for:
299

Description

I’m having a hard time with some bug reports regarding VeraCrypt volumes. It might help if the whisperback reports would not only include mounted volumes, but also unmounted but unlocked ones.

A useful list of unlocked devices can be retrieved with this command:

dmsetup ls --tree -o blkdevname,uuid,active,open,rw,notrunc

The list of loop devices could also be helpful:

losetup -l -O NAME,BACK-FILE,AUTOCLEAR,RO,PARTSCAN,SIZELIMIT,OFFSET


Subtasks


History

#1 Updated by segfault 2018-10-07 18:42:28

  • Target version set to Tails_3.10.1

#2 Updated by intrigeri 2018-10-10 11:06:26

  • Assignee set to segfault
  • Parent task set to Feature #14477
  • Affected tool set to WhisperBack
  • Deliverable for set to 299

Yeah, good idea!

Implementation wise, my 2cts: I suspect lsblk --all --output <some suitable list of columns> will give you the info you need, possibly more nicely. But whatever works for you will be great :)

Regarding who shall implement this: given the need first arose as part of Feature #14477 and I don’t recall needing the requested info to debug other kinds of issues, IMO that’s part of your Feature #14477 work (sorry…). I don’t see who else should feel responsible for implementing this.

#3 Updated by segfault 2018-10-14 15:12:00

  • Assignee changed from segfault to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to feature/15966-dm-and-loop-debug-output

intrigeri wrote:
> Implementation wise, my 2cts: I suspect lsblk --all --output <some suitable list of columns> will give you the info you need, possibly more nicely.

Thanks for the suggestion, but that doesn’t include dm specific information like the encryption type (e.g. CRYPT_LUKS1 or CRYPT_TCRYPT) and loop device specific information like the auto-clear property.

#4 Updated by segfault 2018-10-14 16:11:18

  • Status changed from Confirmed to In Progress

Applied in changeset commit:93979c75ef4872fde6aebea2ee4dcc94646c3ce9.

#5 Updated by intrigeri 2018-10-15 08:51:03

  • Assignee changed from intrigeri to segfault
  • % Done changed from 0 to 60
  • QA Check changed from Ready for QA to Dev Needed

I assume you’ve checked how this renders in the WhisperBack UI; I don’t think it’s worth the effort to actually send a bug report and asking help desk to resend it back to you.

commit:93979c75ef4872fde6aebea2ee4dcc94646c3ce9 LGTM but it’s based on devel (+ another unmerged branch), while presumably we want to ship this in 3.10 (October), not in 3.12 (January). Feel free to merge into stable (and in turn into devel) a rebased branch whose only commit on top of stable is 93979c75ef4872fde6aebea2ee4dcc94646c3ce9, rebased (i.e. essentially, cherry-pick 93979c75ef4872fde6aebea2ee4dcc94646c3ce9 on stable). Thanks!

#6 Updated by segfault 2018-10-15 19:45:08

  • QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:
> I assume you’ve checked how this renders in the WhisperBack UI

Yes, I did.

> commit:93979c75ef4872fde6aebea2ee4dcc94646c3ce9 LGTM but it’s based on devel (+ another unmerged branch), while presumably we want to ship this in 3.10 (October), not in 3.12 (January).

Right, I had merged the two branches which fixed stable to FTBFS (at least the systemd gid issue also affected stable when I tried to build it).

I now rebased on stable.

#7 Updated by segfault 2018-10-16 08:56:55

  • Assignee changed from segfault to intrigeri

#8 Updated by intrigeri 2018-10-16 09:03:06

  • % Done changed from 60 to 70

Code review passes, merged locally, will push once I’ve validated the other branches I’ve merged here.

#9 Updated by intrigeri 2018-10-16 10:31:52

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 70 to 100
  • QA Check changed from Ready for QA to Pass

Merged!

#10 Updated by CyrilBrulebois 2018-10-24 11:19:07

  • Status changed from Fix committed to Resolved