Bug #15954

Fix VeraCrypt volumes not being automatically opened in Nautilus when they should

Added by segfault 2018-09-14 10:48:18 . Updated 2018-10-04 10:42:50 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.9.1
Start date:
2018-09-14
Due date:
% Done:

100%

Feature Branch:
segfault:bugfix/15954-veracrypt-volumes-not-opened
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
299

Description

Opening a volume via Nautilus’ “Open With Unlock VeraCrypt Volumes” should automatically open the volume in Nautilus after unlocking it, but this fails with:

INFO:unlock_veracrypt_volumes.volume:Unlocking volume /dev/loop1
INFO:unlock_veracrypt_volumes.volume:Opening volume /dev/dm-1
Traceback (most recent call last):
  File "/usr/local/lib/python3/dist-packages/unlock_veracrypt_volumes/volume.py", line 227, in mount_cb
    self.open()
  File "/usr/local/lib/python3/dist-packages/unlock_veracrypt_volumes/volume.py", line 273, in open
    mount_points = self.udisks_object.get_filesystem().props.mount_points
AttributeError: 'NoneType' object has no attribute 'props'

Subtasks

History

#1 Updated by segfault 2018-09-18 19:44:12

  • Assignee changed from segfault to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to segfault:bugfix/15954-veracrypt-volumes-not-opened

#2 Updated by intrigeri 2018-09-19 08:49:02

#3 Updated by intrigeri 2018-09-20 04:54:00

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 50

Thanks. I’ll check how it goes with the newly written automated tests; they might need to be adjusted. So reviewing this will take a little more time than usual. I expect I’ll be able to do that next week.

#4 Updated by intrigeri 2018-09-30 16:20:40

I’ve pushed test/14471-veracrypt+15954-veracrypt-volumes-not-opened which merges your branch with the one where I wrote the test suite. Let’s see how it goes on Jenkins.

#5 Updated by intrigeri 2018-10-01 13:17:23

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

Test suite passes => merged!

#6 Updated by intrigeri 2018-10-01 13:29:39

  • Target version changed from Tails_3.10.1 to Tails_3.9.1

#7 Updated by anonym 2018-10-04 10:42:50

  • Status changed from Fix committed to Resolved