Bug #15952

VeraCrypt keyfile widget in GNOME Disks is unreachable with the keyboard

Added by intrigeri 2018-09-13 17:59:57 . Updated 2019-11-24 08:51:25 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Accessibility
Target version:
Tails_4.1
Start date:
2018-09-13
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
299

Description

Noticed while writing the automated tests. Apparently it’s not on the list of widgets one can select with “TAB”. Also, it has no description (in accerciser speak, probably translates to tooltip in GTK). Both combined make it very hard to interact with programmatically, and probably impossible with at least some kinds of universal access technologies.

MR: https://gitlab.gnome.org/GNOME/gnome-disk-utility/merge_requests/24

Subtasks

History

#1 Updated by intrigeri 2018-09-13 18:01:32

For avoidance of doubt, I’m talking about the combo box that ones need to click in order to select a keyfile.

#2 Updated by segfault 2018-09-18 20:31:06

I couldn’t figure out why the widget can’t be focussed. I filed a ticket upstream: https://gitlab.gnome.org/GNOME/gnome-disk-utility/issues/102

#3 Updated by segfault 2018-10-23 22:37:15

  • Target version changed from Tails_3.10.1 to Tails_3.11

#4 Updated by intrigeri 2018-10-31 15:31:44

I would consider the upstream bug you’ve filed (can you reproduce on current sid BTW?) + adding the missing tooltip sufficient to close this ticket. Any chance this happens within a week, before we write the final report for this project?

#5 Updated by intrigeri 2018-10-31 15:31:53

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 20

#6 Updated by segfault 2018-11-06 13:55:16

intrigeri wrote:
> I would consider the upstream bug you’ve filed (can you reproduce on current sid BTW?) + adding the missing tooltip sufficient to close this ticket. Any chance this happens within a week, before we write the final report for this project?

I created a merge request upstream: https://gitlab.gnome.org/GNOME/gnome-disk-utility/merge_requests/10

I would like to wait for upstream’s opinion before backporting the patch.

#7 Updated by CyrilBrulebois 2018-12-16 13:59:21

  • Target version changed from Tails_3.11 to Tails_3.12

#8 Updated by anonym 2019-01-30 11:59:19

  • Target version changed from Tails_3.12 to Tails_3.13

#9 Updated by CyrilBrulebois 2019-03-20 14:34:07

  • Target version changed from Tails_3.13 to Tails_3.14

#10 Updated by intrigeri 2019-03-20 16:14:04

  • Status changed from In Progress to Resolved
  • % Done changed from 20 to 100

segfault wrote:
> I would like to wait for upstream’s opinion before backporting the patch.

Your MR was merged and in the meantime, I wrote the tests in some other way, so don’t bother backporting for Tails. If the tests are fragile due to this problem, I’ll reopen and will ask you to backport :)

#11 Updated by intrigeri 2019-05-05 08:23:54

  • Target version changed from Tails_3.14 to Tails_3.13.2

#12 Updated by anonym 2019-05-06 15:03:13

  • Target version changed from Tails_3.13.2 to Tails_3.14

#13 Updated by intrigeri 2019-05-06 18:15:38

  • Target version changed from Tails_3.14 to Tails_3.13.2

#14 Updated by intrigeri 2019-08-19 13:41:50

@segfault, while working on Feature #15946, I noticed that there’s no a11y relationship defined between the “Keyfiles” label and the combo box. While for example, the “PIM” label is marked as labeling the corresponding text field, which is super useful for me to write these tests, but also presumably for folks using a screen reader.

If you’d like, I can file a ticket about this.

#15 Updated by segfault 2019-08-27 22:51:17

  • Description updated
  • Status changed from Resolved to In Progress
  • Target version changed from Tails_3.13.2 to Tails_3.16

intrigeri wrote:
> @segfault, while working on Feature #15946, I noticed that there’s no a11y relationship defined between the “Keyfiles” label and the combo box. While for example, the “PIM” label is marked as labeling the corresponding text field, which is super useful for me to write these tests, but also presumably for folks using a screen reader.

I created a MR upstream.

#16 Updated by CyrilBrulebois 2019-09-05 00:05:36

  • Target version changed from Tails_3.16 to Tails_3.17

#17 Updated by intrigeri 2019-09-12 14:25:17

  • Target version changed from Tails_3.17 to Tails_4.0

#18 Updated by intrigeri 2019-10-21 11:46:12

  • Target version changed from Tails_4.0 to Tails_4.1

#19 Updated by segfault 2019-11-24 08:51:25

  • Status changed from In Progress to Resolved
  • Assignee deleted (segfault)

Our upstream MR has been merged.