Bug #15911

Leftover config/chroot_local-includes/usr/share/polkit-1/actions/org.boum.tails.additional-software.policy in Git

Added by intrigeri 2018-09-04 06:41:25 . Updated 2018-12-16 13:22:22 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.11
Start date:
2018-09-04
Due date:
% Done:

100%

Feature Branch:
bugfix/15911-leftover-asp-policy
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Additional Software Packages
Deliverable for:
319

Description

6818d283b8193b6ca6931f375bc34e5373984734 on the bugfix/14598-asp-review-bugs branch adds config/chroot_local-includes/usr/share/polkit-1/actions/org.boum.tails.additional-software.policy.in but ./config/chroot_local-includes/usr/share/polkit-1/actions/org.boum.tails.additional-software.policy is still tracked in Git. I guess that’s an oversight since that file will be auto-generated at build time, no?

Subtasks

History

#1 Updated by Anonymous 2018-10-16 13:47:17

  • Target version changed from Tails_3.10.1 to Tails_3.11
  • Deliverable for changed from 299 to 319

#2 Updated by CyrilBrulebois 2018-10-22 13:35:29

The leftover file appeared as modified by the po refresh process, on my way to release 3.10; currently considering removing this file before the 3.10 release.

#3 Updated by segfault 2018-10-22 18:09:28

IMO the fix is to 1. remove the file, and 2. add the path to .gitignore, in the # Files managed by intltool section, so that it is ignored if it’s created by refresh-translations.

#4 Updated by CyrilBrulebois 2018-10-23 10:52:21

  • Status changed from Confirmed to In Progress

Applied in changeset commit:4a606d8442de7e1564a9bcb85bd31d431bfc15b8.

#5 Updated by alant 2018-10-23 18:07:43

  • Assignee changed from alant to CyrilBrulebois
  • % Done changed from 0 to 30
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/15911-leftover-asp-policy

The file is recreated by update-translations so I added it to .gitignore.

#6 Updated by intrigeri 2018-10-31 14:54:27

  • Assignee changed from CyrilBrulebois to intrigeri

#7 Updated by intrigeri 2018-10-31 15:05:20

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 30 to 100
  • QA Check changed from Ready for QA to Pass

#8 Updated by Anonymous 2018-10-31 16:01:18

Thanks! I am unparenting this because it makes my life easier :)

#9 Updated by CyrilBrulebois 2018-12-16 13:22:22

  • Status changed from Fix committed to Resolved