Tails

#5 Updated by segfault 2019-04-12 20:11:29

A lot of tests failed. I merged current stable and now wait for new Jenkins test results.

#7 Updated by intrigeri 2019-04-13 08:12:46

/me is eager to learn: why do we want to do this? FWIW my /usr/bin has 286 instances of /usr/bin/python* vs. 35 instances of /usr/bin/env python*.

#8 Updated by segfault 2019-04-13 18:25:04

intrigeri wrote:
> /me is eager to learn: why do we want to do this? FWIW my /usr/bin has 286 instances of /usr/bin/python* vs. 35 instances of /usr/bin/env python*.

intrigeri: That's a best practice for managing Python versions. I don't think it really matters in the context of Tails, but for example if you would install Python to /usr/local/bin, then the shebang /usr/bin/python@ would use the wrong version, while /usr/bin/env just always uses the one env finds first in $PATH. Also, many Python developers use one of the many tools for virtual Python environments, some of which modify the $PATH variable in order to specify the correct Python version for the environment.

#9 Updated by intrigeri 2019-04-13 18:41:02

Thanks @segfault!

#10 Updated by segfault 2019-04-19 15:37:25

The change to the new shebang caused oniongrater to fail, so I reverted this change for oniongrater.

After that, the only remaining failing test is the fillram test. It fails because pidof -x apparently doesn’t find processes started with /usr/bin/env python instead of /usr/bin/python. We use pidof -x on multiple occasions in our test suite, so if any of the other scripts for which we changed the shebang is called via any of the helper functions that use pidof -x, we will run into this issue again in the future. So we would have to find a workaround for all occasions where we currently use pidof -x.

Since the improvement we gain from this ticket is minor and solely pro forma, I suggest we don’t spend even more time on it and reject it instead. If we do that, I could create a separate branch for Bug #15845 so we can still test and merge that one.