Bug #15841

"Totem could not display the help contents"

Added by segfault 2018-08-25 13:39:48 . Updated 2018-10-04 10:43:07 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Start date:
2018-08-25
Due date:
% Done:

100%

Feature Branch:
segfault:bugfix/15841-allow-yelp-in-totem
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

The AppArmor profile for GNOME Videos aka Totem doesn’t allow executing /usr/bin/yelp, which causes the following error message when trying to open the help in Totem:

Totem could not display the help contents
Failed to execute child process "yelp" (Permission denied)

I tested this on 3.8 and 3.9~rc1 and both are affected.


Subtasks


Related issues

Blocked by Tails - Bug #15821: Video playback broken on some Intel graphics cards (regression in 3.9~rc1) Resolved 2018-08-20

History

#1 Updated by segfault 2018-08-25 13:56:23

  • Assignee set to intrigeri
  • QA Check set to Info Needed

It works after applying the following patch to the AppArmor profile:

--- usr.bin.totem.orig  2018-08-25 13:53:20.600000000 +0000
+++ usr.bin.totem   2018-08-25 13:47:15.392000000 +0000
@@ -9,11 +9,13 @@
   #include <abstractions/ibus>
   #include <abstractions/python>
   #include <abstractions/totem>
+  #include <abstractions/ubuntu-helpers>

   # Maybe in an abstraction?
   /usr/include/**/pyconfig.h r,

   /usr/bin/totem r,
+  /usr/bin/yelp Cx -> sanitized_helper,
   /usr/bin/totem-video-thumbnailer Pix,
   /usr/lib/@{multiarch}/libtotem-plparser[0-9]*/totem-pl-parser/* ix,
   /dev/sr* r,

I guess we should upstream this, right?

#2 Updated by intrigeri 2018-08-26 05:24:14

  • Assignee changed from intrigeri to segfault
  • QA Check deleted (Info Needed)

Yes. The upstream file lives at https://gitlab.com/apparmor/apparmor-profiles/blob/master/ubuntu/18.10/usr.bin.totem.

#3 Updated by intrigeri 2018-08-30 03:53:04

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

https://gitlab.com/apparmor/apparmor-profiles/merge_requests/27 merged upstream :)

#4 Updated by intrigeri 2018-08-30 04:18:32

  • blocked by Bug #15821: Video playback broken on some Intel graphics cards (regression in 3.9~rc1) added

#5 Updated by intrigeri 2018-08-30 04:18:59

Please base your work on my branch for Bug #15821 otherwise it’ll be painful to merge.

#6 Updated by segfault 2018-09-03 19:22:48

  • Feature Branch set to bugfix/15841-allow-yelp-in-totem

#7 Updated by segfault 2018-09-04 09:17:05

  • Target version changed from Tails_3.9 to Tails_3.10.1

#8 Updated by segfault 2018-09-04 19:35:39

  • Assignee changed from segfault to intrigeri
  • QA Check set to Ready for QA

#9 Updated by intrigeri 2018-09-10 09:15:25

  • Feature Branch changed from bugfix/15841-allow-yelp-in-totem to segfault:bugfix/15841-allow-yelp-in-totem

#10 Updated by intrigeri 2018-09-10 09:17:08

  • % Done changed from 10 to 60

Code review passes, now waiting for CI results.

#11 Updated by intrigeri 2018-09-11 07:17:53

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 60 to 100
  • QA Check changed from Ready for QA to Pass

Merged!

#12 Updated by intrigeri 2018-10-01 13:29:42

  • Target version changed from Tails_3.10.1 to Tails_3.9.1

#13 Updated by anonym 2018-10-04 10:43:07

  • Status changed from Fix committed to Resolved