Bug #15802

New ASP code breaks creating new empty persistence config files when permissions are incorrect

Added by intrigeri 2018-08-17 13:08:03 . Updated 2018-09-05 16:10:42 .

Status:
Resolved
Priority:
High
Assignee:
Category:
Persistence
Target version:
Tails_3.9
Start date:
2018-08-17
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Additional Software Packages
Deliverable for:
299

Description

The fix for Bug #15781 (commit:f7c31127c5b039f03414fae1c63c4be21b6cc3e4) changed the API of disable_and_create_empty_persistence_conf_file and create_empty_persistence_conf_file to fix the bug I had reported, but it did not update all callers of these functions accordingly, so at least 3 of them are now broken: they’re going to call install --mode "" which won’t work.

Please review all users of the function you’ve modified and adjust them. Or give these functions safe defaults back, that your specific use case can override.

This is a blocker for 3.9.

Subtasks

History

#1 Updated by alant 2018-08-18 08:59:00

I’ll do that shortly.

#2 Updated by Anonymous 2018-08-19 10:59:55

Seems this is the only big blocker right now.

#3 Updated by alant 2018-08-19 21:04:59

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 20
  • QA Check set to Ready for QA

#4 Updated by alant 2018-08-26 16:51:46

  • Deliverable for set to 299

#5 Updated by alant 2018-08-26 22:56:23

  • Assignee changed from alant to segfault
  • % Done changed from 20 to 40

#6 Updated by segfault 2018-09-01 10:02:45

  • Assignee changed from segfault to alant
  • QA Check changed from Ready for QA to Pass

LGTM

#7 Updated by intrigeri 2018-09-01 10:10:55

  • Assignee changed from alant to intrigeri

Thanks! I’ll take one last look and will merge.

#8 Updated by intrigeri 2018-09-01 10:19:14

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 40 to 100

Merged and wrote a merge commit message that describes what the problem we’re fixing is (instead of merely paraphrasing the diff).

#9 Updated by intrigeri 2018-09-01 14:22:42

  • Status changed from Fix committed to In Progress

Applied in changeset commit:31c1a8c64653fc1b883367c94b4299d068fdb176.

#10 Updated by intrigeri 2018-09-01 15:14:45

  • Status changed from In Progress to Fix committed

#11 Updated by intrigeri 2018-09-05 16:10:42

  • Status changed from Fix committed to Resolved