Feature #15793

Improve ownership test in tails-debugging-info

Added by segfault 2018-08-15 18:04:23 . Updated 2019-05-06 14:23:44 .

Status:
Confirmed
Priority:
Normal
Assignee:
segfault
Category:
Target version:
Start date:
2018-08-15
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Currently, we only print a warning if the file that is going to be printed by tails-debugging-info is not owned by the user that was configured in /etc/whisperback/debugging-info.json.

We could improve it by:

  • Also checking whether the file is a symlink that is not owned by the correct user
  • Also check all the parent directories

See https://labs.riseup.net/code/issues/8514#note-58 for a proposed patch for the first point.

Additionally, since we ported tails-debugging-info to Python, we always open the file to be printed as root, while before we opened it as the user which is now configured in /etc/whisperback/debugging-info.json. We should fix that.

Subtasks

Related issues

Related to Tails - Feature #8514: Replace WhisperBack.mail_appended_info with a dictionary Resolved 2015-01-02

History

#1 Updated by segfault 2018-08-15 18:05:17

  • related to Feature #8514: Replace WhisperBack.mail_appended_info with a dictionary added

#2 Updated by segfault 2018-08-15 18:10:16

  • Description updated

#3 Updated by CyrilBrulebois 2018-12-16 14:04:37

  • Target version changed from Tails_3.11 to Tails_3.12

#4 Updated by anonym 2019-01-30 11:59:32

  • Target version changed from Tails_3.12 to Tails_3.13

#5 Updated by CyrilBrulebois 2019-03-20 14:34:10

  • Target version changed from Tails_3.13 to Tails_3.14

#6 Updated by segfault 2019-05-06 14:23:44

  • Target version deleted (Tails_3.14)