Bug #15731

Let OnionShare use the default GNOME theme

Added by segfault 2018-07-16 11:07:58 . Updated 2019-05-24 06:06:51 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_4.0
Start date:
2018-07-16
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
OnionShare
Deliverable for:

Description

Currently, our AppArmor profile denies access to /usr/lib/x86_64-linux-gnu/qt5/plugins/styles/adwaita.so, so OnionShare can’t use the default GNOME theme. We could fix this by adding this line to the AppArmor profile, allowing OnionShare to load and execute the shared object of the qt5 plugin for the theme:

/usr/lib/x86_64-linux-gnu/qt5/plugins/styles/adwaita.so m

Subtasks

History

#1 Updated by Anonymous 2018-07-22 09:18:24

  • Assignee deleted (None)

I’ll propose this upstream. Thanks!

#2 Updated by intrigeri 2018-07-22 11:30:20

> I’ll propose this upstream. Thanks!

Cool!

I think this should be added to some appropriate abstraction (as opposed to the OnionShare profile itself).

#3 Updated by intrigeri 2018-08-15 13:46:05

  • Affected tool set to OnionShare

Upstream now has a qt5 abstraction: https://gitlab.com/apparmor/apparmor/blob/master/profiles/apparmor.d/abstractions/qt5. It’s not part of any upstream release yet but we could temporarily backport it.

And in passing, the AppArmor profile for onionshare-gui still includes the gnome abstraction while we’ve upgraded to a version that uses Qt. I’m not sure whether that abstraction is still needed.

#4 Updated by intrigeri 2018-08-15 13:47:44

u wrote:
> I’ll propose this upstream. Thanks!

For this to be useful, the Debian package will need to actually install these profiles and we’ll have to drop our own copy :)

#5 Updated by Anonymous 2019-03-18 15:57:10

  • Target version set to Tails_3.14

Let’s try to do that once the 2.0 packaging is ready.

#6 Updated by CyrilBrulebois 2019-05-23 21:23:26

  • Target version changed from Tails_3.14 to Tails_3.15

#7 Updated by intrigeri 2019-05-24 06:06:51

  • Status changed from Confirmed to Resolved
  • Target version changed from Tails_3.15 to Tails_4.0

On feature/buster, onionshare-gui correctly uses the Adwaita theme and I see no such denial in the logs, so I don’t think it’s worth spending time on fixing this in Tails 3.x ⇒ closing with target version = 4.0 :)