Bug #15730

run_test_suite: Don't try and use XVFB_PID if it's not defined.

Added by lamby 2018-07-16 08:45:36 . Updated 2018-09-05 16:20:26 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Tails_3.9
Start date:
2018-07-16
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

We try and use XVFB_PID in the cleanup, even though it’s not guaranteed to be defined. This results in an ugly and (moreover) misleading ./run_test_suite: line 145: XVFB_PID: unbound variable message.

Patch attached.

Files

0001-run_test_suite-Don-t-try-and-use-XVFB_PID-if-it-s-no.patch (749 B) lamby, 2018-07-16 08:43:44

Subtasks

History

#1 Updated by intrigeri 2018-07-25 00:46:42

  • Status changed from New to In Progress
  • Target version set to Tails_3.9
  • Type of work changed from Test to Code

#2 Updated by intrigeri 2018-07-28 02:39:40

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 0 to 100
  • QA Check changed from Ready for QA to Pass

Applied on stable then merged into devel. Thanks!

#3 Updated by lamby 2018-07-29 15:08:45

  • Status changed from Fix committed to In Progress

Applied in changeset commit:189f46a3991ea2e3f62810ba15478e8e276fb57b.

#4 Updated by intrigeri 2018-07-30 02:39:10

  • Status changed from In Progress to Fix committed

#5 Updated by intrigeri 2018-09-05 16:20:26

  • Status changed from Fix committed to Resolved