Bug #15727

Please make it more obvious that the .orig file check is fatal

Added by lamby 2018-07-13 11:07:39 . Updated 2018-09-05 16:21:30 .

Status:
Resolved
Priority:
Low
Assignee:
Category:
Build system
Target version:
Tails_3.9
Start date:
2018-07-13
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

When patches are fuzzy and leave .orig files around, we bail out of the build. However, without some kind of “error” / “fatal” or even “E:” prefix it is not obvious whether this a warning or a fatal error.

Trivial patch attached that uses E: to match the live-build style.

Files

foo.diff (637 B) lamby, 2018-07-13 11:06:39

Subtasks

History

#1 Updated by intrigeri 2018-07-25 00:47:45

  • Status changed from New to In Progress
  • Target version set to Tails_3.9

#2 Updated by intrigeri 2018-07-28 02:40:26

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 0 to 100
  • QA Check changed from Ready for QA to Pass

Applied on stable then merged into devel. Thanks!

Note that we have quite a few other similar “print error and then exit != 0” in hooks but that’s no reason not to improve things incrementally.

#3 Updated by intrigeri 2018-07-29 15:08:43

  • Status changed from Fix committed to In Progress

Applied in changeset commit:a0aef6947ca9f5ccd124956b0b188d53dade35af.

#4 Updated by intrigeri 2018-07-30 02:39:03

  • Status changed from In Progress to Fix committed

#5 Updated by intrigeri 2018-09-05 16:21:30

  • Status changed from Fix committed to Resolved