Bug #15715

Translatable strings for the torstatus GNOME Shell extension are not taken into account

Added by intrigeri 2018-07-05 08:19:56 . Updated 2018-09-05 16:21:30 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Tails_3.9
Start date:
2018-07-05
Due date:
% Done:

100%

Feature Branch:
bugfix/15715-torstatus-l10n
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Onion Circuits
Deliverable for:

Description

refresh-translations extracts them into tmp/pot/extension.js.pot but then nothing more happens because that file is not in po/POTFILES.in. So the strings (e.g. “Open Onion Circuits”) don’t end up in tails.pot, never get translated, and are always displayed in English in the GUI.

Subtasks

Related issues

Blocks Tails - Feature #15334: Core work 2018Q3: Foundations Team Resolved 2018-02-20

History

#1 Updated by intrigeri 2018-08-07 15:21:43

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • Feature Branch set to bugfix/15715-torstatus-l10n

#2 Updated by intrigeri 2018-08-08 07:22:31

  • Assignee changed from intrigeri to segfault
  • % Done changed from 10 to 50
  • Estimated time set to 0 h
  • QA Check set to Ready for QA

I’ve built an ISO, started it in French, clicked the Tor Status icon and verified that “Open Onion Circuits” text is correctly translated into French. So I think all you need to do is a quick code review of my (trivial) changes. Thanks in advance!

#3 Updated by segfault 2018-08-14 15:38:26

  • Assignee changed from segfault to intrigeri
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

LGTM

#4 Updated by intrigeri 2018-08-14 16:20:03

  • Assignee deleted (intrigeri)

Woohoo! Merged into stable and in turn into devel.

#5 Updated by intrigeri 2018-08-14 16:20:14

  • Status changed from In Progress to Fix committed

#6 Updated by intrigeri 2018-09-05 16:21:30

  • Status changed from Fix committed to Resolved

#7 Updated by segfault 2018-10-03 10:07:22