Bug #15706

Tor Browser 8 always prompts wrt. asking webpages in English

Added by intrigeri 2018-07-03 15:25:15 . Updated 2018-09-05 16:15:51 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Tails_3.9
Start date:
2018-07-03
Due date:
% Done:

100%

Feature Branch:
feature/15803-tor-browser-8.0a10+force-all-tests
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

… when started in a non-English locale. That is, extensions.torbutton.prompted_language is not honored.

Subtasks

Related issues

Related to Tails - Feature #15023: Upgrade to Tor Browser based on Firefox ESR60 Resolved 2017-08-30 2018-08-09
Blocks Tails - Feature #15334: Core work 2018Q3: Foundations Team Resolved 2018-02-20
Blocked by Tails - Feature #15803: Upgrade Tor Browser to 8.0a10 Resolved 2018-08-18

History

#1 Updated by intrigeri 2018-07-03 15:25:22

#2 Updated by intrigeri 2018-07-03 18:57:39

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

intrigeri wrote:
> … when started in a non-English locale. That is, extensions.torbutton.prompted_language is not honored.

I’ve set a pref that will be useful in the future. With this in place, the prompt should disappear once https://trac.torproject.org/projects/tor/ticket/26409 is fixed. Worst case, I will submit a branch to drop the now useless code in Torbutton.

#3 Updated by intrigeri 2018-07-07 14:26:02

  • Type of work changed from Code to Communicate

#4 Updated by intrigeri 2018-08-08 08:44:09

  • % Done changed from 10 to 50

The upstream fix works for me so we now only have to wait for a new build that includes it.

#5 Updated by intrigeri 2018-08-08 14:57:44

  • Type of work changed from Communicate to Wait

#6 Updated by intrigeri 2018-08-14 05:49:02

(Unparenting so I can mark Feature #15023 as fix committed.)

#7 Updated by intrigeri 2018-08-14 05:49:10

  • related to Feature #15023: Upgrade to Tor Browser based on Firefox ESR60 added

#8 Updated by intrigeri 2018-08-18 12:11:28

  • Feature Branch set to feature/15803-tor-browser-8.0a10+force-all-tests
  • Type of work changed from Wait to Code

#9 Updated by intrigeri 2018-08-18 12:11:54

#10 Updated by intrigeri 2018-08-18 19:02:37

  • % Done changed from 50 to 100

That’s fixed on the topic branch.

#11 Updated by intrigeri 2018-08-19 15:59:17

  • Assignee changed from intrigeri to segfault
  • QA Check set to Ready for QA

(To test this, one needs to log in with non-English.)

#12 Updated by segfault 2018-08-25 11:10:20

  • QA Check changed from Ready for QA to Pass

Tested, works for me

#13 Updated by intrigeri 2018-08-26 05:55:45

  • Status changed from In Progress to Fix committed
  • Assignee deleted (segfault)

#14 Updated by intrigeri 2018-09-05 16:15:51

  • Status changed from Fix committed to Resolved