Bug #15656

Fix minor bug that prevents greater's from locking partitions

Added by Gaff 2018-06-14 13:55:15 . Updated 2018-09-05 16:21:30 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.9
Start date:
2018-06-14
Due date:
% Done:

100%

Feature Branch:
tails:feature/15653-15656-greeter-unlock,greeter:feature/15653-15656-greeter-unlock
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Looks like a bug was introduced while refactoring the code at some point. This one-liner fixes that.

No material impact since the greeter doesn’t currently implement locking but worth fixing so that future lock-implementers aren’t left with a nasty surprise.

Files

greeter3.patch (605 B) Gaff, 2018-06-14 13:54:41

Subtasks

History

#1 Updated by Gaff 2018-06-14 13:55:31

  • Subject changed from Fix minor bug that prevents greater's from locking python partitions to Fix minor bug that prevents greater's from locking partitions

#2 Updated by intrigeri 2018-06-14 14:32:35

Please follow the “Submit your work” section of https://tails.boum.org/contribute/how/code/ once you’re done.

#3 Updated by Gaff 2018-06-14 16:59:05

  • QA Check set to Ready for QA

#4 Updated by intrigeri 2018-06-14 17:42:03

  • Assignee set to intrigeri
  • Target version set to Tails_3.9

(Not worth introducing in 3.8 since it does not fix any actual bug.)

#5 Updated by intrigeri 2018-06-18 06:58:38

  • % Done changed from 0 to 20
  • Feature Branch set to tails:feature/15653-15656-greeter-unlock,greeter:feature/15653-15656-greeter-unlock

Applied in a topic branch, let’s see how it fares on Jenkins.

#6 Updated by intrigeri 2018-06-19 16:11:42

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 20 to 100
  • QA Check changed from Ready for QA to Pass

Merged, thanks!

#7 Updated by intrigeri 2018-09-05 16:21:30

  • Status changed from Fix committed to Resolved