Bug #15597

Fix color scheme of buttons in /upgrade

Added by Anonymous 2018-05-08 14:58:19 . Updated 2018-06-11 11:40:54 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Start date:
2018-05-08
Due date:
% Done:

100%

Feature Branch:
web/15597-upgrade-buttons
Type of work:
Website
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

- on /upgrade buttons look weird: they have two background colors, green and blue.
- on the homepage the title border looks ugly

I’m proposing a branch to fix these two issues, as people started wondering. Please review and cherry-pick what you like.

Files

install.png (63888 B) sajolida, 2018-05-14 18:56:03
upgrade.png (91012 B) sajolida, 2018-05-14 18:56:04

Subtasks

Related issues

Related to Tails - Feature #11493: Installation Assistant: please merge /install and /install/os Resolved 2016-05-27
Related to Tails - Feature #15114: Avoid styling headers like buttons Resolved 2017-12-26

History

#1 Updated by Anonymous 2018-05-08 14:58:46

  • related to Feature #11493: Installation Assistant: please merge /install and /install/os added

#2 Updated by Anonymous 2018-05-08 14:59:06

  • Description updated

#3 Updated by Anonymous 2018-05-08 15:02:25

  • Status changed from Confirmed to In Progress

sajolida, talking to people on tails-dev, we decided to merge this right away. Please revert it if you don’t like it. My two commits were

commit 5e629cd736d68bd7533eacee55835aa06d9ce96a
commit 2359e02905b743fce64972d02649e7dc01539800

#4 Updated by Anonymous 2018-05-08 15:07:25

also added these commits

commit 17a16171083830f6a926a6569c87548dccec06fe
commit 09877a40d2678665864e8853586536e77d033c30

feel free to revert if you dont agree.

#5 Updated by sajolida 2018-05-14 18:29:26

  • Subject changed from Colorscheme in stylesheet to Fix color scheme of buttons in /upgrade

Improve ticket title.

#6 Updated by sajolida 2018-05-14 18:43:25

#7 Updated by sajolida 2018-05-14 19:00:38

  • File install.png added
  • File upgrade.png added
  • Assignee deleted (sajolida)
  • QA Check set to Ready for QA
  • Feature Branch changed from feature/fix_colors to web/15597-upgrade-buttons

Thanks for acting quickly as soon as you saw the problem.

Regarding your fix, they left /install and /upgrade with a different style (and less contrast in colors on the buttons on /upgrade). See screenshots in attachment.

17a16171083830f6a926a6569c87548dccec06fe also broke the alignment of “Other Linux” on /install.

I fixed the root cause of the bug differently in web/15597-upgrade-buttons. I basically forgot to update /upgrade while working on Feature #15114.

This time I also did git grep panel wiki/src to check that nothing else was left behind :)

If that might help for the future, I personally don’t think that having broken colors on our website requires entering in emergency mode and act that fast. In this case it might have help solving the problem with less work overall.

#8 Updated by sajolida 2018-05-14 19:02:46

Ah, and I’m fine removing the

tags for the same reason a Feature #15114#note-2: the same text is already put in another

on top of the page.

#9 Updated by Anonymous 2018-06-11 11:37:22

> If that might help for the future, I personally don’t think that having broken colors on our website requires entering in emergency mode and act that fast. In this case it might have help solving the problem with less work overall.

Hm, I did that without waiting waiting for you because I had at least two people from frontdesk talking to me about it on XMPP and being sure that it must have been a mistake.

#10 Updated by Anonymous 2018-06-11 11:40:54

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100
  • QA Check changed from Ready for QA to Pass

Ack, merged.