Bug #15590

Installer reinstall option displays incorrect stick capacity

Added by cbrownstein 2018-05-07 15:26:44 . Updated 2018-09-05 16:24:01 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Installation
Target version:
Start date:
2018-05-07
Due date:
% Done:

100%

Feature Branch:
bugfix/15590-14849-14720-14810-installer-fixes-for-3.9, installer:bugfix/15590-14849-14720-14810-installer-fixes-for-3.9
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Installer
Deliverable for:

Description

In Tails Installer, “Target USB stick” displays the capacity of the USB stick. However, the “Reinstall (delete all data)” option displays the size of the Tails partition, rather than the capacity of the USB stick. The inconsistency might suggest to the user that Tails Installer is detecting another USB stick or that there is some kind of error.

@emmapeel has confirmed this bug.


Files


Subtasks


Related issues

Blocked by Tails - Bug #14810: Tails Installer allows buggy "Reinstall (delete all data)" on too small USB sticks Resolved 2017-10-07

History

#1 Updated by intrigeri 2018-05-28 16:55:40

  • Assignee set to kurono

kurono, wanna take a look?

#2 Updated by kurono 2018-06-19 21:08:36

  • Assignee changed from kurono to emmapeel
  • QA Check changed from Dev Needed to Info Needed

intrigeri wrote:
> kurono, wanna take a look?

I cannot reproduce this. More info about it? Like a screenshot.

#3 Updated by cbrownstein 2018-06-19 23:55:58

Hi!

kurono wrote:
> I cannot reproduce this. More info about it? Like a screenshot.

I’m adding screenshots to this ticket. 128 GB is the correct capacity of the drive.

#4 Updated by kurono 2018-06-20 15:13:38

  • Assignee deleted (kurono)
  • Target version set to Tails_3.8
  • QA Check changed from Info Needed to Ready for QA
  • Feature Branch set to bug/15590-incorrect-stick-capacity

#5 Updated by intrigeri 2018-06-23 07:26:13

  • Assignee set to intrigeri
  • Target version changed from Tails_3.8 to Tails_3.9

#6 Updated by intrigeri 2018-06-28 16:29:38

  • Status changed from Confirmed to In Progress
  • Assignee changed from intrigeri to kurono
  • QA Check changed from Ready for QA to Info Needed

Please rebase your work on top of the current upstream master branch, as opposed to the packaging (tails/master) branch.

#7 Updated by kurono 2018-06-29 00:33:53

  • Assignee changed from kurono to intrigeri
  • QA Check changed from Info Needed to Ready for QA

intrigeri wrote:
> Please rebase your work on top of the current upstream master branch, as opposed to the packaging (tails/master) branch.

Done.

#8 Updated by intrigeri 2018-06-29 15:58:26

  • % Done changed from 0 to 60

Code review passes. I’ll test in a batch with Feature #14720 and Bug #14810 once the latter is ready.

#9 Updated by intrigeri 2018-06-29 15:59:12

  • blocked by Bug #14810: Tails Installer allows buggy "Reinstall (delete all data)" on too small USB sticks added

#10 Updated by intrigeri 2018-07-10 13:06:00

Merged into bugfix/15590-14849-14720-14810-installer-fixes-for-3.9 (both liveusb-creator.git and tails.git) except the logo change (quilt won’t take binary stuff), built and uploaded a package.

#11 Updated by intrigeri 2018-07-11 08:38:11

Test suite passes on Jenkins. Next step: test manually to confirm the bugs the branch is meant to fix are gone and that nothing else is broken.

#12 Updated by intrigeri 2018-07-11 19:30:13

  • % Done changed from 60 to 90
  • QA Check changed from Ready for QA to Pass
  • Feature Branch changed from bug/15590-incorrect-stick-capacity to bugfix/15590-14849-14720-14810-installer-fixes-for-3.9, installer:bugfix/15590-14849-14720-14810-installer-fixes-for-3.9

I confirm this fixes the bug and the “Reinstall” feature still works.

#13 Updated by intrigeri 2018-07-11 19:46:13

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 90 to 100

Merged into devel!

#14 Updated by intrigeri 2018-08-02 01:38:09

  • Status changed from Fix committed to In Progress

Applied in changeset commit:f5fbe30b80aaefa335f286c8f7a7abb5cd519207.

#15 Updated by intrigeri 2018-08-02 05:49:34

  • Status changed from In Progress to Fix committed

#16 Updated by intrigeri 2018-09-05 16:24:01

  • Status changed from Fix committed to Resolved