Bug #15550

Attempting to delete an unlocked persistent volume does not tell the user anything useful

Added by alant 2018-04-22 07:35:01 . Updated 2018-04-27 10:06:47 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Persistence
Target version:
Tails_3.7
Start date:
2018-04-22
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Additional Software Packages
Deliverable for:
299

Description

In tails-amd64-feature_14594-asp-gui-3.9-20180420T2055Z-e6f49b3f4f+devel@886427ce28.iso nightly ISO, “Delete Persistent Volume” is broken.

tails-persistence-delete.desktop[10550]: In fun get_variable_from_file: parameter 1 ($file): Reference bless( ["/var/lib/live/config/tails.persistence","/var/lib/l...) did not pass type constraint "Str" at /usr/share/perl5/Tails/Persistence/Setup.pm line 758.

Subtasks

History

#1 Updated by sajolida 2018-04-23 17:27:07

#2 Updated by sajolida 2018-04-23 17:27:16

  • Affected tool set to Additional Software Packages

#3 Updated by intrigeri 2018-04-27 09:16:11

  • Category set to Persistence
  • Target version set to Tails_3.7

#4 Updated by intrigeri 2018-04-27 09:25:04

(AFAIK and according to Redmine, user testing did not happen yet and it’s blocked by the doc anyway.)

#5 Updated by intrigeri 2018-04-27 09:46:31

  • Subject changed from Delete persistent volume is broken to Deleting an unlocked persistent volume is broken

#6 Updated by intrigeri 2018-04-27 09:58:01

  • Subject changed from Deleting an unlocked persistent volume is broken to Attempting to delete an unlocked persistent volume does not tell the user anything useful

#7 Updated by intrigeri 2018-04-27 10:06:47

  • Status changed from Confirmed to Resolved
  • Assignee deleted (intrigeri)
  • % Done changed from 0 to 100

Fixed on the topic branch.

Post mortem: I did not notice this bug earlier as our automated test suite only exercises deleting a persistent volume that hasn’t been unlocked (which works fine) and I did not think about trying this out manually myself. The fallout of that bug (had Alan not noticed it) would have been poor UX when a user tries to do that. If such a user had submitted a bug report, presumably help desk would have noticed that they were trying to delete an unlocked persistent volume and told them it’s not supported.