Feature #15527

Adjust the UI strings of Additional Software to the ones designed in the wireframes

Added by sajolida 2018-04-12 17:30:58 . Updated 2018-07-17 13:34:44 .

Status:
Resolved
Priority:
Normal
Assignee:
sajolida
Category:
Target version:
Tails_3.9
Start date:
2018-04-12
Due date:
% Done:

80%

Feature Branch:
bugfix/15527-additional-software-strings
Type of work:
User interface design
Blueprint:

Starter:
Affected tool:
Additional Software Packages
Deliverable for:
299

Description

I see many unconsistencies (and typos) between the wireframes that we agreed upon with Alan during the UX sprint and the actual code.

Subtasks

History

#1 Updated by sajolida 2018-04-12 17:31:23

  • Description updated

#2 Updated by sajolida 2018-04-12 17:48:07

  • Assignee changed from sajolida to alant
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/15527-additional-software-strings

Alan, please have a look at my branch.

I did a few more commits on top of adjusting the strings to the wireframe, but I took care of splitting them in atomic commits to make your review easier.

#3 Updated by sajolida 2018-04-12 17:49:55

  • Subject changed from Correct the displayed message of Additional Software as designed in the wireframes to Adjust the UI strings of Additional Software to the ones designed in the wireframes

#4 Updated by alant 2018-04-22 07:00:24

  • Assignee changed from alant to sajolida
  • % Done changed from 0 to 50
  • QA Check changed from Ready for QA to Info Needed

Thanks for the review. I merged the branch.

However, since the strings review, the error notification on “apt update” failure was
the same than when “apt upgrade” fails. I think it’s worth making a diffrence in the error message.
When APT update fails, I propose “The check for upgrades of your additional software failed” instead of “The upgrade of your additional software failed”.

#5 Updated by alant 2018-04-22 16:39:01

  • Status changed from Confirmed to In Progress

Applied in changeset commit:20e3b46fadea27cafee1ba9a98587b2de0831420.

#6 Updated by sajolida 2018-04-23 17:30:16

  • Assignee changed from sajolida to alant
  • QA Check changed from Info Needed to Dev Needed

I saw that and wondered why we had two different messages :) Now I understand that the difference is “update” vs “upgrade”. But I’m fine with your string :)

#7 Updated by alant 2018-04-28 17:51:00

  • Status changed from In Progress to Resolved
  • Assignee deleted (alant)

#8 Updated by alant 2018-04-28 17:51:13

  • % Done changed from 50 to 100

#9 Updated by sajolida 2018-07-02 11:10:32

  • Status changed from Resolved to In Progress
  • Assignee set to alant
  • Target version changed from Tails_3.7 to Tails_3.9
  • QA Check changed from Dev Needed to Ready for QA

I pushed more fixes to this branch since Alan did the first merge. Please have a look again.

git log -p origin/feature/14594-asp-gui..origin/bugfix/15527-additional-software-strings

#10 Updated by sajolida 2018-07-02 11:10:41

  • Deliverable for set to 299

#11 Updated by alant 2018-07-03 00:24:50

  • Assignee changed from alant to sajolida
  • % Done changed from 100 to 80
  • QA Check changed from Ready for QA to Info Needed

There is lots of merge conflicts when trying to merge this branch, but going through them I don’t see the string changes that are still missing, so I’m afraid that merging it again may break things without benefit. Could you please point me to the commits that are not yet merged?

#12 Updated by alant 2018-07-03 00:31:36

The last commit I have is c3be53d, which is merged.

#13 Updated by sajolida 2018-07-17 13:34:44

  • Status changed from In Progress to Resolved
  • QA Check deleted (Info Needed)

Ok. I’m not sure what happened but I merged again my branch into doc/14589-additional-software just in case.