Bug #15468

Make the WhisperBack reports more helpdesk-friendly

Added by goupille 2018-03-28 13:41:19 . Updated 2018-06-10 12:59:42 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.7.1
Start date:
2018-03-28
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
1
Affected tool:
WhisperBack
Deliverable for:

Description

by default, if, in the body of an email, there is a line like this one :

--

(“— ”), Thunderbird see the rest of the message as a signature. unfortunately there is a line like that in the whisperback reports, so it doesn’t quote it when replying. That make it uneasy to forward the logs to FT or to point the user to some parts of the logs.

We should empty those lines e.g. s/^--\s*//. The mail_appended_info function in source:config/chroot_local-includes/etc/whisperback/config.py is probably the best place to do that.

This change be initially tested without building a Tails ISO: patch code in a running Tails and send a bug report that asks our help desk to confirm whether it’s better for them.

Files

0001-bug-15468-Make-the-WhisperBack-reports-more-helpdesk.patch (1212 B) sascha.markus@gmail.com, 2018-05-16 11:45:12
0001-bugfix-15468-make-reports-helpdesk-friendly.patch (1195 B) sascha.markus@gmail.com, 2018-05-28 19:35:45

Subtasks

Related issues

Blocks Tails - Feature #15139: Core work 2018Q2: Foundations Team Resolved 2018-01-01

History

#1 Updated by intrigeri 2018-03-29 15:08:30

  • Description updated

#2 Updated by intrigeri 2018-03-29 15:16:46

#3 Updated by intrigeri 2018-03-29 15:19:02

  • Description updated
  • Starter set to Yes

Let’s see if the FT has time for that in Q2.

#4 Updated by intrigeri 2018-03-29 15:19:38

  • Assignee deleted (intrigeri)
  • Type of work changed from Research to Code

#5 Updated by intrigeri 2018-04-08 15:03:42

  • Subject changed from make the Whisperback reports more helpdesk friendly to Make the WhisperBack reports more helpdesk-friendly

#6 Updated by intrigeri 2018-04-08 15:06:38

  • Description updated

#7 Updated by intrigeri 2018-04-13 14:49:29

  • Assignee set to CyrilBrulebois
  • Target version set to Tails_3.7
  • Estimated time set to 1 h

#8 Updated by bertagaz 2018-05-10 11:09:33

  • Target version changed from Tails_3.7 to Tails_3.8

#9 Updated by goupille 2018-05-15 23:04:02

I’m a bit confused about the reply email address on the bug report we received, but it is definitely more helpdesk friendly, thanks !

#10 Updated by sascha.markus@gmail.com 2018-05-16 11:47:27

Well, I used my mail address in case you would reply to it. :-)

Here is the patch I used to send the error report.

#11 Updated by intrigeri 2018-05-24 09:35:37

  • Status changed from Confirmed to In Progress
  • Assignee changed from CyrilBrulebois to sascha.markus@gmail.com
  • % Done changed from 0 to 30
  • re.sub(r'--\s', '' is too broad IMO: any reason not to anchor this with ^ as suggested in the ticket description?
  • Note that this ticket was assigned to Cyril. In the future, when working on a ticket that’s already assigned to someone, please coordinate with them in order to avoid duplicated work :)
  • This being said, well, what’s done is done, Cyril has plenty of other Tails work on his plate, and you’re pretty close to a mergeable fix, so if you could complete this work in time for the 3.8 release (deadline: June 19), it would be sweet!

#12 Updated by sascha.markus@gmail.com 2018-05-28 19:42:20

Here is a new patch using the regex from the bug description.

I’ll get in touch with the assignee next time.

#13 Updated by intrigeri 2018-05-29 06:09:07

  • Estimated time deleted (1 h)
  • QA Check set to Ready for QA

#14 Updated by intrigeri 2018-05-29 06:45:44

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 30 to 100
  • QA Check changed from Ready for QA to Pass

Applied to stable & devel after wring an actual commit message. Thanks!

#15 Updated by intrigeri 2018-06-09 15:29:21

  • Target version changed from Tails_3.8 to Tails_3.7.1

#16 Updated by intrigeri 2018-06-10 12:57:21

  • Assignee set to BitingBird

#17 Updated by intrigeri 2018-06-10 12:58:26

  • Assignee deleted (BitingBird)

#18 Updated by intrigeri 2018-06-10 12:59:42

  • Status changed from Fix committed to Resolved