Bug #15462

Purpose of the search box in the documentation browser is unclear

Added by emmapeel 2018-03-27 16:55:31 . Updated 2018-05-10 10:59:51 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.7
Start date:
2018-03-27
Due date:
% Done:

100%

Feature Branch:
segfault:bugfix/15462-fix-search-box
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Steps to reproduce:

- Disconnect Internet

- Click on the Documentation link on Desktop
- Use the searchbox on top

Subtasks

History

#1 Updated by emmapeel 2018-03-27 17:08:13

  • Assignee set to segfault

#2 Updated by segfault 2018-03-27 17:59:27

  • Subject changed from Search box not working on internal documentacion browser to Purpose of the search box in the documentation browser is unclear
  • Assignee changed from segfault to bertagaz
  • Target version set to Tails_3.7
  • QA Check changed from Dev Needed to Ready for QA

This turned out to be a misunderstanding: emmapeel thought the search box would search the text on our whole website and present a page with results. Instead, the search box only searches the current page and highlights the entered string. What makes this especially confusing is that on our website we have a search box for the former use case in the top right corner, similar to the position of the search box in the documentation browser.

To fix this UX issue, I pushed a small patch to bug/15462-fix-search-box in my repo, to only show the search box when Ctrl-f is pressed.

#3 Updated by intrigeri 2018-03-27 19:08:39

  • Assignee changed from bertagaz to anonym

We’re switching to the new FT/RM setup in a few days and the release manager won’t be responsible for reviews anymore.

#4 Updated by intrigeri 2018-04-13 11:38:06

  • Assignee changed from anonym to intrigeri

#5 Updated by intrigeri 2018-04-13 16:33:36

  • Feature Branch set to segfault:bug/15462-fix-search-box

#6 Updated by intrigeri 2018-04-14 07:18:11

  • Status changed from Confirmed to In Progress
  • Assignee changed from intrigeri to segfault
  • % Done changed from 0 to 20
  • QA Check changed from Ready for QA to Dev Needed

Your branch is based on the one for Feature #14594 or similar. Please rebase it on top of current stable.

#7 Updated by segfault 2018-04-14 09:55:18

  • Feature Branch changed from segfault:bug/15462-fix-search-box to segfault:bugfix/15462-fix-search-box

intrigeri wrote:
> Your branch is based on the one for Feature #14594 or similar. Please rebase it on top of current stable.

Done. I also corrected the branch name.

#8 Updated by segfault 2018-04-14 09:56:04

  • Assignee changed from segfault to intrigeri
  • QA Check changed from Dev Needed to Ready for QA

#9 Updated by intrigeri 2018-04-14 10:44:39

  • % Done changed from 20 to 60

I’m no expert in this field but code review looks OK. Will test manually and run our automated test suite.

#10 Updated by intrigeri 2018-04-15 07:56:57

  • Status changed from In Progress to Fix committed
  • % Done changed from 60 to 100

Applied in changeset commit:053941624fb3206b70fa4c7f7aa28e8af63e52b9.

#11 Updated by intrigeri 2018-04-15 07:57:30

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#12 Updated by bertagaz 2018-05-10 10:59:51

  • Status changed from Fix committed to Resolved