Feature #15379

Adjust test suite to Python tails-upgrade-frontend-wrapper

Added by intrigeri 2018-03-05 09:52:27 . Updated 2018-09-05 16:14:39 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Test suite
Target version:
Tails_3.9
Start date:
2018-03-05
Due date:
% Done:

100%

Feature Branch:
test/15379-adjust-to-python-upgrade-wrapper
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Upgrader
Deliverable for:

Description

Our test suite makes assumptions about tails-u-f-w that don’t hold anymore since Feature #11753 was merged:

  • at least sed -i "/^sleep 30$/d" does not work anymore
  • it might be that the process name we want to kill in the recovery function has changed (python? killall -f?)

On my system this causes the “Upgrading Tails with Tails Upgrader through an incremental upgrade” scenario to take ages failing before I get bored and CTRL-C it. IIRC I’ve seen similar problems on Jenkins but I’m not 100% sure.

Subtasks

Related issues

Blocks Tails - Feature #13241: Core work: Test suite maintenance Rejected 2017-06-29

History

#1 Updated by intrigeri 2018-03-05 09:54:07

It might be that this bug is only exposed when recover_from_upgrader_failure is called, i.e. when the first attempt to I am proposed to install an incremental upgrade to […] fails. Which might explain why I see it a lot locally but lizard, with its better Internet connection, does not expose it.

#2 Updated by intrigeri 2018-03-05 09:55:19

Oh, and BTW: tails-upgrade-frontend-wrapper now has a --no-wait option. This should be better than sed -i "/^sleep 30$/d.

#3 Updated by intrigeri 2018-03-05 09:56:27

  • blocks Feature #14595: Code for Additional Software Packages GUI: Persistence Setup added

#4 Updated by bertagaz 2018-03-14 11:32:10

  • Target version changed from Tails_3.6 to Tails_3.7

#5 Updated by intrigeri 2018-04-13 11:33:42

#6 Updated by intrigeri 2018-04-13 11:33:50

  • Assignee deleted (anonym)

#7 Updated by intrigeri 2018-04-14 10:32:40

  • Status changed from Confirmed to In Progress
  • Assignee set to intrigeri
  • % Done changed from 0 to 10
  • Feature Branch set to test/15379-adjust-to-python-upgrade-wrapper

#8 Updated by intrigeri 2018-04-14 15:12:17

  • Assignee changed from intrigeri to anonym
  • QA Check set to Ready for QA

#9 Updated by intrigeri 2018-04-27 11:48:34

  • blocked by deleted (Feature #14595: Code for Additional Software Packages GUI: Persistence Setup)

#10 Updated by bertagaz 2018-05-10 11:09:16

  • Target version changed from Tails_3.7 to Tails_3.8

#11 Updated by intrigeri 2018-06-26 16:27:53

  • Target version changed from Tails_3.8 to Tails_3.9

#12 Updated by intrigeri 2018-06-26 17:13:08

  • Target version changed from Tails_3.9 to Tails_3.10.1

#13 Updated by segfault 2018-08-15 14:35:18

  • Assignee changed from anonym to intrigeri
  • QA Check changed from Ready for QA to Dev Needed

Code review passes, except for one thing:

It’s not regression, but we can either drop the killall tails-upgrade-frontend, or replace it with pkill --full tails-upgrade-frontend, because it’s a perl script and killall won’t ever find a process with tails-upgrade-frontend as the executable name.

#14 Updated by segfault 2018-08-15 14:37:56

segfault wrote:
> It’s not regression, but we can either drop the killall tails-upgrade-frontend, or replace it with pkill --full tails-upgrade-frontend, because it’s a perl script and killall won’t ever find a process with tails-upgrade-frontend as the executable name.

A quick test indicates that I’m wrong here, but I don’t know why

#15 Updated by segfault 2018-08-15 14:42:13

  • QA Check changed from Dev Needed to Pass

#16 Updated by intrigeri 2018-08-15 15:29:44

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • Target version changed from Tails_3.10.1 to Tails_3.9
  • % Done changed from 10 to 100

Merged, thanks!

#17 Updated by intrigeri 2018-09-05 16:14:39

  • Status changed from Fix committed to Resolved