Bug #15311

"Tor check" broken on Spanish translation

Added by sajolida 2018-02-14 15:01:43 . Updated 2018-02-15 11:48:52 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Start date:
2018-02-14
Due date:
% Done:

0%

Feature Branch:
Type of work:
Translate
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

See screenshot in attachment.


Files

tor check.png (143080 B) sajolida, 2018-02-14 15:01:26

Subtasks


Related issues

Related to Tails - Bug #15312: "Tor check" button is badly aligned and looks buggy Resolved 2018-02-15

History

#1 Updated by sajolida 2018-02-14 15:08:29

On the other hand it’s also a bit broken on other languages (but clearly less).

This button is a big hack that I did many years ago and I’m not surprised to see that it broke.

Maybe we should reconsider having such a button…

#2 Updated by emmapeel 2018-02-14 20:50:14

sajolida wrote:
> On the other hand it’s also a bit broken on other languages (but clearly less).
>
> This button is a big hack that I did many years ago and I’m not surprised to see that it broke.
>
> Maybe we should reconsider having such a button…

I am afraid the only thing I can provide on this ticket atm is empathy. I will try and look what is happening, but I already did today and could not see what was wrong if you have a hint, it will be appreciated.

#3 Updated by emmapeel 2018-02-14 20:51:29

  • Assignee deleted (emmapeel)
  • QA Check set to Info Needed

#4 Updated by emmapeel 2018-02-14 23:16:29

  • Status changed from Confirmed to In Progress
  • Assignee set to emmapeel

Oh wait I think I have it

#5 Updated by emmapeel 2018-02-14 23:31:26

  • Assignee changed from emmapeel to sajolida
  • QA Check changed from Info Needed to Ready for QA
  • Feature Branch set to emmapeel:15311-websitebutton

Ey, I think it works better now with the span=‘two lines’>

Please review

https://git-tails.immerda.ch/emmapeel/tails/log/?h=15311-websitebutton

#6 Updated by emmapeel 2018-02-14 23:38:10

  • Priority changed from Normal to Elevated

#7 Updated by sajolida 2018-02-15 11:48:48

  • related to Bug #15312: "Tor check" button is badly aligned and looks buggy added

#8 Updated by sajolida 2018-02-15 11:48:53

  • Status changed from In Progress to Resolved
  • Assignee deleted (sajolida)
  • Priority changed from Elevated to Normal
  • QA Check deleted (Ready for QA)
  • Feature Branch deleted (emmapeel:15311-websitebutton)

Looks good! It’s still badly aligned but it’s the same of other languages and I don’t think you can do better. I’m creating Bug #15312 to solve this on the long term.