Feature #15298

Rebase our Thunderbird custom package on top of 52.6.0

Added by anonym 2018-02-09 12:15:23 . Updated 2018-03-14 11:08:56 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Start date:
2018-02-09
Due date:
% Done:

100%

Feature Branch:
feature/15298-thunderbird-52.6.0
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Email Client
Deliverable for:

Description


Subtasks


Related issues

Blocks Tails - Feature #13245: Core work 2018Q1: Foundations Team Resolved 2017-06-29

History

#1 Updated by intrigeri 2018-02-09 13:08:44

#2 Updated by intrigeri 2018-02-09 13:10:15

  • Status changed from New to Confirmed

#3 Updated by intrigeri 2018-02-09 13:10:23

  • Subject changed from Rebase our Thunderbird custom package on top of 52.6.0 to Rebase our Thunderbird custom package on top of 52.6.0

#4 Updated by intrigeri 2018-02-09 13:21:29

Note that the Vcs-Git moved to Salsa, so our release process doc needs to be adjusted.

#5 Updated by anonym 2018-02-09 20:36:03

  • Status changed from Confirmed to In Progress

Applied in changeset commit:213919ea89fa64f4ccdc48f8d723cfb21789aafd.

#6 Updated by anonym 2018-02-10 13:58:38

  • % Done changed from 0 to 40
  • Feature Branch set to feature/15298-thunderbird-52.6.0

intrigeri wrote:
> Note that the Vcs-Git moved to Salsa, so our release process doc needs to be adjusted.

Thanks! Updated.

#7 Updated by anonym 2018-02-10 16:40:11

  • % Done changed from 40 to 50

thunderbird.feature passes on my system! I was intending to use the same branch for Bug #11973, but let’s not block.

#8 Updated by anonym 2018-02-10 16:40:44

  • Assignee changed from anonym to bertagaz
  • QA Check set to Ready for QA

#9 Updated by intrigeri 2018-02-19 14:27:17

  • Assignee changed from bertagaz to intrigeri

(As per discussion with anonym, in order to make bertagaz’ review plate lighter and increase the chances he can deal with what’s left there in a timely manner.)

#10 Updated by intrigeri 2018-02-19 15:42:53

  • % Done changed from 50 to 60

git diff debian/1%52.6.0-1_deb9u1..debian/52.6.0-1_deb9u1.0tails1 shows that we modify a Debian changelog entry (adding some whitespace). I guess that’s a typo. No idea when it was introduced, not a blocker, but please fix that in our icedove.git.

Other than that, code review passes!

#11 Updated by anonym 2018-02-19 15:47:25

  • % Done changed from 60 to 50

intrigeri wrote:
> git diff debian/1%52.6.0-1_deb9u1..debian/52.6.0-1_deb9u1.0tails1 shows that we modify a Debian changelog entry (adding some whitespace). I guess that’s a typo. No idea when it was introduced, not a blocker, but please fix that in our icedove.git.

Crap, it was done by mistake in one of my merge conflict resolutions. Now fixed, thanks!

#12 Updated by intrigeri 2018-02-19 16:49:56

  • % Done changed from 50 to 60

I should have a full test suite run done within 3.5 hours so expect a merge either late tonight of early tomorrow, if everything goes well :)

#13 Updated by intrigeri 2018-02-19 20:21:25

  • Status changed from In Progress to Fix committed
  • % Done changed from 60 to 100

Applied in changeset commit:51eb29fee10d34b7073db3fa0064151e3571bd61.

#14 Updated by intrigeri 2018-02-19 20:22:07

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#15 Updated by bertagaz 2018-03-14 11:08:56

  • Status changed from Fix committed to Resolved