Bug #15270
devel branch FTBFS since torbrowser-launcher 0.2.9 entered sid
100%
Description
That’s due to the AppArmor profile changes I got upstreamed for Bug #12679. My feature/12679-sandbox-firefox-content-renderers branches (in tails.git and in our torbrowser-launcher repo) might help fixing that if they’re not too outdated.
Feel free to simply downgrade to torbrowser-launcher 0.2.8-6 as a temporary stopgap measure to fix this FTBFS ASAP; and then I’ll handle the next steps myself on Bug #12679.
Subtasks
Related issues
Blocks Tails - |
Resolved | 2017-06-29 | |
Blocks Tails - |
Resolved | 2018-01-23 | |
Blocks Tails - |
Resolved | 2017-12-09 | |
Blocks Tails - Bug #15116: X.Org does not start with some NVidia Maxwell and Pascal graphic cards | Confirmed | 2017-12-27 | |
Blocks Tails - |
Resolved | 2017-08-30 | |
Blocks Tails - |
Resolved | 2018-01-16 | |
Blocks Tails - |
Resolved | 2016-08-27 | |
Blocks Tails - |
Resolved | 2018-02-13 |
History
#1 Updated by anonym 2018-01-30 23:15:15
- Status changed from Confirmed to Fix committed
- Assignee changed from anonym to bertagaz
- % Done changed from 0 to 100
- QA Check set to Ready for QA
intrigeri wrote:
> Feel free to simply downgrade to torbrowser-launcher 0.2.8-6
While that one is in Debian Testing, I thought it would be smarter to downgrade to 0.2.8-5~bpo9+1 so the fix (most likely) will work for us longer, e.g. even if the new version migrates to Debian Testing. I looked at the diff between 0.2.8-5~bpo9+1 and 0.2.8-6, and the AppArmor stuff isn’t touched, so that version is fine (actually, the last change to our patch, commit:63ebac31880fd3415d9f3f0145c49315e46528a4, indicates that 0.2.8-4 would be fine). And devel built successfully locally for me and on jenkins!
bertagaz, please review this already pushed fix! Actually, my main reason for notifying you about this change is so that you are aware that the real fix (Bug #12679) should be in Tails 3.6~rc1, ideally.
#2 Updated by bertagaz 2018-01-31 11:39:01
- Assignee deleted (
bertagaz) - QA Check changed from Ready for QA to Pass
anonym wrote:
> bertagaz, please review this already pushed fix! Actually, my main reason for notifying you about this change is so that you are aware that the real fix (Bug #12679) should be in Tails 3.6~rc1, ideally.
Ok, looks good and works to fix the FTBFS. Thanks for the notice!
#3 Updated by intrigeri 2018-02-04 07:39:37
- Status changed from Fix committed to In Progress
- Assignee set to intrigeri
- % Done changed from 100 to 10
- QA Check changed from Pass to Dev Needed
anonym wrote:
> intrigeri wrote:
> > Feel free to simply downgrade to torbrowser-launcher 0.2.8-6
>
> While that one is in Debian Testing, I thought it would be smarter to downgrade to 0.2.8-5~bpo9+1 so the fix (most likely) will work for us longer
Well, it lasted until 0.2.9 entered stretch-backports yesterday but now devel FTBFS again. I think I failed to communicate my suggestion clearly enough: I meant you could temporarily downgrade to a working version by importing it into our custom APT repo (not by fetching it from Buster which obviously would quickly fail just like fetching it from stretch-backports). I’ll handle the next steps, either via Bug #12679 or here.
#4 Updated by intrigeri 2018-02-05 08:04:31
- blocks
Feature #13245: Core work 2018Q1: Foundations Team added
#5 Updated by intrigeri 2018-02-07 11:06:15
- Assignee changed from intrigeri to bertagaz
- % Done changed from 10 to 50
- QA Check changed from Dev Needed to Ready for QA
- Feature Branch set to feature/12679-sandbox-firefox-content-renderers
This branch fixes the FTBFS, passes the subset of the test suite we run on Jenkins, and passes the relevant scenarios of torified_browsing.feature
, pidgin.feature
, and tor_stream_isolation.feature
locally, except two scenarios (about persistence) that fail, one due to the Tor Browser bug wrt. file:///, the other one (persistent bookmarks) apparently due to a test suite bug that I’ll investigate later on Bug #12679. So please review’n’merge, mostly to fix the FTBFS and unblock other 3.6 dev work, and hope it does not introduce regressions that our test suite didn’t spot. But let’s not close Bug #12679 right away: I want to do more QA and possibly polishing there.
#6 Updated by intrigeri 2018-02-08 06:22:29
- blocks
Bug #15232: Revert to Stretch's xorg-xserver added
#7 Updated by intrigeri 2018-02-08 06:23:37
- blocks
Bug #15029: Check list of backends in the usr.sbin.cups AppArmor profile (2018 edition) added
#8 Updated by intrigeri 2018-02-08 06:24:31
- blocks Bug #15116: X.Org does not start with some NVidia Maxwell and Pascal graphic cards added
#9 Updated by intrigeri 2018-02-08 06:25:17
- blocks
Bug #14521: Improve UX when GDM does not start added
#10 Updated by intrigeri 2018-02-14 08:12:50
- blocks
Bug #12679: Sandbox Tor Browser's content renderer processes more strictly added
#11 Updated by intrigeri 2018-02-14 08:12:58
- blocks
Bug #15173: Upgrade Intel processor microcodes to mitigate the Spectre attack added
#12 Updated by intrigeri 2018-02-14 09:25:28
- blocked by deleted (
)Bug #12679: Sandbox Tor Browser's content renderer processes more strictly
#13 Updated by intrigeri 2018-02-19 09:07:40
- blocks
Feature #11753: Port complex shell scripts shipped in /usr/local to Python added
#14 Updated by intrigeri 2018-02-19 09:07:57
- blocks
Feature #15309: Upgrade to Linux 4.15 added
#15 Updated by anonym 2018-02-19 14:24:50
- Assignee changed from bertagaz to anonym
I’m taking this one over to relieve our overloaded RM, and to get stuff building again!
#16 Updated by anonym 2018-02-19 18:54:54
- Status changed from In Progress to Fix committed
- Assignee deleted (
anonym) - % Done changed from 50 to 100
- QA Check changed from Ready for QA to Pass
Works for me!
#17 Updated by bertagaz 2018-03-14 11:08:55
- Status changed from Fix committed to Resolved