Convert ASP to Python3 and follow PEP-8
As noted on
>> According to PEP 8, one-line docstrings should have the closing “”" on the same line.
> I agree, but fixing it here without doing it in all the file looks wierd, so I propose to forget about it for now, and do it later on when converting this file to python3. I plan to do that after all branches are merged and tests are written.
#3 Updated by alant 2018-01-29 10:54:02
- Status changed from Confirmed to In Progress
- Assignee changed from alant to segfault
- QA Check set to Ready for QA
- Feature Branch set to feature/15198-asp-convert-to-python3-pep8
This branch is ready. Please note it is based on
feature/14572-automated-tests-for-ASP-offline-mode and should wait for it to be merged.
#12 Updated by anonym 2018-02-19 11:11:07
- % Done changed from 0 to 50
- QA Check changed from Ready for QA to Pass
> Looks good to me.
Same! Not merging due to the blockers.
> The only remaining ugly code is the
f.closed in line 83, which has no effect.
Nice catch! I fixed it myself (commit:b25e43c985eee068f3a8349ccb2e10a099ec10e7) and will keep this ticket until the blockers are merged or back on my plate.
#13 Updated by anonym 2018-02-19 13:49:56
- Assignee changed from anonym to bertagaz
> I […] will keep this ticket until the blockers are merged or back on my plate.
Actually that doesn’t make sense. The blockers are on bert’s plate, so this one should be as well. But only the merge remains!
#15 Updated by bertagaz 2018-02-20 20:31:28
- Assignee deleted (
> Applied in changeset commit:8469c983425a0a3a47e38fbac9d7b47f24b8ce87.
With commit:82bb83f7 it works just fine, so it’s meged into devel for 3.6. I don’t know how people tested that though, adding ‘3’ to the shebang wasn’t enough clearly.