Bug #15198

Convert ASP to Python3 and follow PEP-8

Added by Anonymous 2018-01-19 09:46:57 . Updated 2018-03-14 11:16:12 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.6
Start date:
2018-01-19
Due date:
% Done:

100%

Feature Branch:
feature/15198-asp-convert-to-python3-pep8
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Additional Software Packages
Deliverable for:
299

Description

As noted on Feature #14570:

>> According to PEP 8, one-line docstrings should have the closing “”" on the same line.
> I agree, but fixing it here without doing it in all the file looks wierd, so I propose to forget about it for now, and do it later on when converting this file to python3. I plan to do that after all branches are merged and tests are written.

Subtasks

Related issues

Blocked by Tails - Feature #14570: Implement Offline Mode for Additional Software Packages Resolved 2016-01-17
Blocked by Tails - Feature #14572: Implement automated tests for Additional Software/Offline Mode Resolved 2017-08-30 2018-01-15

History

#1 Updated by Anonymous 2018-01-19 09:47:07

  • related to Feature #14570: Implement Offline Mode for Additional Software Packages added

#2 Updated by alant 2018-01-20 21:16:33

  • Subject changed from Convert ASP offline mode code to Python3 wrt PEP-8 to Convert ASP to Python3 and follow PEP-8

#3 Updated by alant 2018-01-29 10:54:02

  • Status changed from Confirmed to In Progress
  • Assignee changed from alant to segfault
  • QA Check set to Ready for QA
  • Feature Branch set to feature/15198-asp-convert-to-python3-pep8

This branch is ready. Please note it is based on feature/14572-automated-tests-for-ASP-offline-mode and should wait for it to be merged.

#4 Updated by sajolida 2018-02-05 13:12:48

  • Deliverable for set to 299

#5 Updated by Anonymous 2018-02-05 13:52:20

  • Target version set to Tails_3.6

#6 Updated by Anonymous 2018-02-05 13:56:29

  • related to deleted (Feature #14570: Implement Offline Mode for Additional Software Packages)

#7 Updated by Anonymous 2018-02-05 13:57:15

  • blocked by Feature #14570: Implement Offline Mode for Additional Software Packages added

#8 Updated by Anonymous 2018-02-05 13:57:29

  • blocks deleted (Feature #14570: Implement Offline Mode for Additional Software Packages)

#9 Updated by Anonymous 2018-02-05 13:57:53

  • blocked by Feature #14570: Implement Offline Mode for Additional Software Packages added

#10 Updated by Anonymous 2018-02-05 13:58:01

  • blocked by Feature #14572: Implement automated tests for Additional Software/Offline Mode added

#11 Updated by segfault 2018-02-10 09:27:33

  • Assignee changed from segfault to anonym

Looks good to me. The only remaining ugly code is the f.closed in line 83, which has no effect.

#12 Updated by anonym 2018-02-19 11:11:07

  • % Done changed from 0 to 50
  • QA Check changed from Ready for QA to Pass

segfault wrote:
> Looks good to me.

Same! Not merging due to the blockers.

> The only remaining ugly code is the f.closed in line 83, which has no effect.

Nice catch! I fixed it myself (commit:b25e43c985eee068f3a8349ccb2e10a099ec10e7) and will keep this ticket until the blockers are merged or back on my plate.

#13 Updated by anonym 2018-02-19 13:49:56

  • Assignee changed from anonym to bertagaz

anonym wrote:
> I […] will keep this ticket until the blockers are merged or back on my plate.

Actually that doesn’t make sense. The blockers are on bert’s plate, so this one should be as well. But only the merge remains!

#14 Updated by bertagaz 2018-02-20 20:14:24

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:8469c983425a0a3a47e38fbac9d7b47f24b8ce87.

#15 Updated by bertagaz 2018-02-20 20:31:28

  • Assignee deleted (bertagaz)

bertagaz wrote:
> Applied in changeset commit:8469c983425a0a3a47e38fbac9d7b47f24b8ce87.

With commit:82bb83f7 it works just fine, so it’s meged into devel for 3.6. I don’t know how people tested that though, adding ‘3’ to the shebang wasn’t enough clearly.

#16 Updated by bertagaz 2018-03-14 11:16:12

  • Status changed from Fix committed to Resolved