Tails

#1 Updated by sajolida 2017-12-21 12:46:02

• Assignee changed from sajolida to intrigeri
• QA Check set to Ready for QA

Done in eda4cd1. I subscribed to those feeds.

intrigeri: Is this what you were thinking about?

#3 Updated by intrigeri 2017-12-22 08:18:18

• Status changed from Confirmed to In Progress
• Assignee changed from intrigeri to sajolida
• % Done changed from 0 to 70
• QA Check changed from Ready for QA to Dev Needed

This is misleading:

sed -i '1s/^/\/*! Forge v$VERSION | (c) Digital Bazaar, Inc. | github.com\/digitalbazaar\/forge\/raw\/master\/LICENSE *\/\n/' scripts/vendor/forge.min.js

At first glance one may think they should set the VERSION environment variable and then run this command, which won’t work due to the single quotes. If we expect the reader to do the shell’s job (variable interpolation) themselves, IMO it should be made explicit. But the code seems to work just fine if I replace the single quotes with double quotes, so maybe just do that?

Otherwise, looks good to me :)

#4 Updated by sajolida 2017-12-22 17:48:08

• Assignee changed from sajolida to intrigeri
• QA Check changed from Dev Needed to Ready for QA

Yeah, that was clearly misleading and it’s doesn’t cost much more to be more explicit.

Done in 3e939d2 (hopefully!).

#5 Updated by intrigeri 2017-12-22 19:33:37

• Status changed from In Progress to Resolved
• Assignee deleted (intrigeri)
• % Done changed from 70 to 100
• QA Check changed from Ready for QA to Pass