Bug #14971

Remove translations of translations (sic) on unsafe browser warning

Added by sajolida 2017-11-16 18:12:15 . Updated 2017-12-08 16:01:04 .

Status:
Resolved
Priority:
Elevated
Assignee:
intrigeri
Category:
Target version:
Tails_3.5
Start date:
2017-11-16
Due date:
% Done:

100%

Feature Branch:
Type of work:
Website
Blueprint:

Starter:
Affected tool:
Unsafe Browser
Deliverable for:

Description

Doing ls -1 misc/unsafe_browser_warning.* produces:

misc/unsafe_browser_warning.de.de.po
misc/unsafe_browser_warning.de.fa.po
misc/unsafe_browser_warning.de.fr.po
misc/unsafe_browser_warning.de.html
misc/unsafe_browser_warning.de.it.po
misc/unsafe_browser_warning.de.pt.po
misc/unsafe_browser_warning.en.de.po
misc/unsafe_browser_warning.en.fa.po
misc/unsafe_browser_warning.en.fr.po
misc/unsafe_browser_warning.en.html
misc/unsafe_browser_warning.en.it.po
misc/unsafe_browser_warning.en.pt.po
misc/unsafe_browser_warning.fa.de.po
misc/unsafe_browser_warning.fa.fa.po
misc/unsafe_browser_warning.fa.fr.po
misc/unsafe_browser_warning.fa.html
misc/unsafe_browser_warning.fa.it.po
misc/unsafe_browser_warning.fa.pt.po
misc/unsafe_browser_warning.fr.de.po
misc/unsafe_browser_warning.fr.fa.po
misc/unsafe_browser_warning.fr.fr.po
misc/unsafe_browser_warning.fr.html
misc/unsafe_browser_warning.fr.it.po
misc/unsafe_browser_warning.fr.pt.po
misc/unsafe_browser_warning.it.de.po
misc/unsafe_browser_warning.it.fa.po
misc/unsafe_browser_warning.it.fr.po
misc/unsafe_browser_warning.it.html
misc/unsafe_browser_warning.it.it.po
misc/unsafe_browser_warning.it.pt.po
misc/unsafe_browser_warning.pot
misc/unsafe_browser_warning.pt.html

So it seems like 08259afa44 didn’t disable the PO plugin on the static HTML pages.

Subtasks

Related issues

Blocks Tails - Feature #13244: Core work 2017Q4: Foundations Team Resolved 2017-06-29

History

#1 Updated by intrigeri 2017-12-07 13:01:17

#2 Updated by intrigeri 2017-12-07 13:01:27

  • Priority changed from Normal to Elevated

#3 Updated by intrigeri 2017-12-07 13:01:55

  • Assignee changed from anonym to intrigeri

#4 Updated by intrigeri 2017-12-08 09:18:59

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

sajolida wrote:
> So it seems like 08259afa44 didn’t disable the PO plugin on the static HTML pages.

It did, but this change was not applied on our production website configuration (nor to ikiwiki-cgi.setup by the way) so once pushed there, ikiwiki in the production environment generated the missing PO files (commit:37980b83fd96cb52f7c6ee47596671fa076b0592).

#5 Updated by intrigeri 2017-12-08 09:22:20

Actually commit:a02aafefe1c3850461d28a44befd2378fe527741 changed this again, reverting 08259afa44 and doing another change that was not conveyed to our production website config.

#6 Updated by intrigeri 2017-12-08 10:14:11

  • % Done changed from 10 to 30

I think I’m done, pushed to master. I’m building an ISO from devel + master merged into it to ensure this still works.

I have no idea how this exclude directive still allows copying the files unmodified, whatever.

#7 Updated by intrigeri 2017-12-08 16:01:04

  • Status changed from In Progress to Resolved
  • % Done changed from 30 to 100

Fixed, but again I don’t understand why it works at all, so it’d better be temporary as the commit message says. When this gets reverted, please coordinate with me so the config of our production web site is kept in sync.