Bug #14958

Tails Installer 5.0 proposes to upgrade even if the destination stick is already up-to-date

Added by intrigeri 2017-11-11 13:25:38 . Updated 2019-07-22 16:10:19 .

Status:
Confirmed
Priority:
Normal
Assignee:
Category:
Installation
Target version:
Start date:
2017-11-11
Due date:
% Done:

0%

Feature Branch:
Type of work:
User interface design
Blueprint:

Starter:
Affected tool:
Installer
Deliverable for:

Description

Previously the user would choose themselves in the splash screen what operation they wanted to do, so if they selected “Upgrade” they would not be surprised when they were proposed to upgrade the destination stick, even if it was already up-to-date.

Now, we autodetect that the destination device already has Tails, and when it’s the case we automatically propose the user to “Ugrade” it, which has been confusing for at least one user.

I don’t know how severe this is. I would suggest asking Help Desk if they got reports about it. Feel free to triage this out of Feature #9005 if you want.

The aforementioned report suggests solutions, not sure what they’re worth. Note that fixing this might be tricky, in particular when one considers the case when the destination device has a nightly build installed (it’ll always tell it’s the next version of Tails, while it’s older).


Subtasks


Related issues

Related to Tails - Bug #14810: Tails Installer allows buggy "Reinstall (delete all data)" on too small USB sticks Resolved 2017-10-07
Related to Tails - Bug #14622: Have the Installer detect when "Clone the current Tails" won't fit in the destination partition before deleting anything Resolved 2017-09-11
Blocked by Tails - Bug #8862: Display version number of destination device in Tails Installer Confirmed 2015-02-04

History

#1 Updated by Anonymous 2018-01-15 15:29:42

  • Assignee set to sajolida
  • Type of work changed from Code to User interface design

As this is a result of Feature #9005, I’m leaving the ticket here for the time being. I think @sajolida should first have a look from an UX point of view before we can write code to fix this issue. Assigning this to him, so he can decide how to continue.

#2 Updated by Anonymous 2018-01-18 18:34:07

  • related to Bug #14810: Tails Installer allows buggy "Reinstall (delete all data)" on too small USB sticks added

#3 Updated by sajolida 2018-01-19 15:54:05

  • related to Bug #8862: Display version number of destination device in Tails Installer added

#4 Updated by sajolida 2018-01-19 15:54:47

  • related to Bug #14622: Have the Installer detect when "Clone the current Tails" won't fit in the destination partition before deleting anything added

#5 Updated by sajolida 2018-01-19 16:34:06

I think that the proper solution for that goes through Bug #8862. Once we’re able to display the version number in Tails Installer:

  • Users will be able to tell before attempting the upgrade that it’s not needed.
  • Tails Installer will be able to know the Tails version of a USB stick.

If solving this ticket before solving Bug #8862 implies weird stuff like mounting every possible USB as described in Bug #14622#note-11:

> note that Bug #14958 will require mounting these filesystems as well, if we ever want to address it; I seem
> to remember there’s a way to temporary disable these notifications (that we already display sometimes),
> not sure if it’s real and suitable here; in any case I’m pretty sure the resulting code will make an
> ugly, hard to understand/debug part of the code even worse;

Then it might not be worth it…

So I feel like we need to discuss possible solutions to Bug #8862 first.

#6 Updated by intrigeri 2018-01-19 17:03:52

> I think that the proper solution for that goes through Bug #8862. Once we’re able to display the version number in Tails Installer:

Fully agreed.

#7 Updated by sajolida 2018-03-27 11:50:18

  • related to deleted (Bug #8862: Display version number of destination device in Tails Installer)

#8 Updated by sajolida 2018-03-27 11:50:29

  • blocked by Bug #8862: Display version number of destination device in Tails Installer added

#9 Updated by sajolida 2018-03-27 11:50:40

  • Assignee deleted (sajolida)
  • Type of work changed from User interface design to Wait

#10 Updated by intrigeri 2019-03-08 16:19:31

  • Type of work changed from Wait to User interface design

#11 Updated by Anonymous 2019-03-08 16:20:34

Let’s keep the correct type of work.

#12 Updated by sajolida 2019-07-22 16:10:19

Unparenting this from Feature #9005 so we can close it.