Bug #14852

"Installation Assistant" over logo in banner on smaller screens

Added by sajolida 2017-10-16 14:29:31 . Updated 2018-01-22 18:09:33 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Installation
Target version:
Tails_3.5
Start date:
2017-10-16
Due date:
% Done:

0%

Feature Branch:
feature/14852-remove-tails-assistant-in-banner
Type of work:
Website
Blueprint:

Starter:
Affected tool:
Installation Assistant
Deliverable for:

Description

See attachment.

Files

screencapture-tails-boum-org-install-1508112310159.png (63013 B) sajolida, 2017-10-16 14:29:22

Subtasks

History

#1 Updated by sajolida 2017-10-16 14:31:34

  • Affected tool set to Installation Assistant

#2 Updated by sajolida 2017-10-19 08:48:19

  • Target version set to Tails_3.3

u partially did that with 01bb8cf57aa594e776b1e7b466cadcb53d6cbf5d for the donation banner.

But seeing:

-.banner {
-  height: 70px;
-}

And:

+#tails-installation-assistant {
+    display: none;
+}
+

I suspect that the layout will get broken once we remove the donation banner.

#3 Updated by sajolida 2017-10-22 16:11:53

  • Assignee deleted (sajolida)
  • QA Check set to Ready for QA
  • Feature Branch set to feature/14852-remove-tails-assistant-in-banner

#4 Updated by Anonymous 2017-10-30 10:40:12 

+#tails-installation-assistant {
+    display: none;
+}
+

I’m unsure why you talk about this part? It’s not part of my commit.

d832844ad5d wiki/src/install/inc/stylesheets/assistant.css (tchou 2016-01-19 10:52:26 +0100 297) #tails-installation-assistant {
d832844ad5d wiki/src/install/inc/stylesheets/assistant.css (tchou 2016-01-19 10:52:26 +0100 298) display: none;
d832844ad5d wiki/src/install/inc/stylesheets/assistant.css (tchou 2016-01-19 10:52:26 +0100 299) }

So I’m basically unsure here what the problem you try to solve is.

#5 Updated by Anonymous 2017-10-30 10:53:36

  • Assignee set to sajolida

Can you please clarify?

#6 Updated by Anonymous 2017-10-30 10:53:46

  • QA Check changed from Ready for QA to Info Needed

#7 Updated by sajolida 2017-11-10 18:13:44

  • Assignee deleted (sajolida)
  • QA Check changed from Info Needed to Ready for QA

Sorry I was unclear. Let’s me explain this better.

  • In the CSS for the donation banner (donate-banner.css) you’re hiding the special treatment of the banner on the installation pages (dc45de843c). This CSS will only be in production while the donation campaign lasts.
  • With 01bb8cf57a you are changing the height of the banner on the installation pages. This CSS will remain in production even after the donation campaign is over.

My bet (I didn’t test) is that once we remove donate-banner.css at the end of the donation campaign, the layout of the banner on the installation pages will be broken by dc45de843c.

So my branch is being proactive and cleaning the code generating this special treatment everywhere.

This can be reviewed and merged at any time you please as long as it’s done before the end of the donation campaign.

#8 Updated by anonym 2017-11-15 11:30:58

  • Target version changed from Tails_3.3 to Tails_3.5

#9 Updated by intrigeri 2017-12-23 08:41:06

  • Status changed from Confirmed to In Progress

#10 Updated by Anonymous 2018-01-22 18:09:33

  • Status changed from In Progress to Resolved
  • QA Check changed from Ready for QA to Pass

I had to recreate this commit manually. There were too many conflicts and the commit was for some reason impossible to cherry pick.