Bug #14772

Test suite reports incomplete (and thus useless) info when systemctl is-system-running fails

Added by intrigeri 2017-10-04 09:06:16 . Updated 2017-11-15 11:33:49 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
2017-10-04
Due date:
% Done:

100%

Feature Branch:
test/14772-log-more-useful-info-when-is-system-running-fails
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Listing the units is not enough: in most cases I’ve seen, is-system-running returns “starting” which means the job queue is not empty, and to debug that we need the list of jobs.

I’m aware anonym and I might not agree about whether we should run is-system-running in “Tor is ready”, but I think we have another ticket to discuss that, and regardless where this code moves the proposed change will be useful so let’s not block on orthogonal discussions :)


Subtasks


Related issues

Blocks Tails - Feature #13240: Core work 2017Q4: Test suite maintenance Resolved 2017-06-29

History

#1 Updated by intrigeri 2017-10-04 09:08:11

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • QA Check set to Ready for QA
  • Feature Branch set to test/14772-log-more-useful-info-when-is-system-running-fails

#2 Updated by intrigeri 2017-10-04 14:11:42

  • Assignee changed from intrigeri to anonym
  • % Done changed from 10 to 50

#3 Updated by intrigeri 2017-10-04 14:12:24

  • blocks Feature #13240: Core work 2017Q4: Test suite maintenance added

#4 Updated by anonym 2017-10-11 10:18:19

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

Merged! As discussed on XMPP, I also committed commit:dd985681bfc29f0fdf00a4ac762208b215579be7 on top (and now I realize its Will-fix: probably should’ve been a Refs:), which actually might also solve the root cause for this error. We’ll see!

#5 Updated by anonym 2017-10-11 10:44:37

  • Status changed from Fix committed to In Progress

Applied in changeset commit:dd985681bfc29f0fdf00a4ac762208b215579be7.

#6 Updated by intrigeri 2017-11-06 18:09:52

  • Status changed from In Progress to Fix committed

#7 Updated by anonym 2017-11-15 11:33:49

  • Status changed from Fix committed to Resolved