Bug #14602
devel branch FTBFS since torbrowser-launcher 0.2.8-1 made it into Debian
100%
Description
Subtasks
Related issues
Blocks Tails - |
Resolved | 2017-06-29 |
History
#1 Updated by intrigeri 2017-09-05 06:35:35
- blocks
Feature #13234: Core work 2017Q3: Foundations Team added
#2 Updated by intrigeri 2017-09-05 06:54:03
- Status changed from Confirmed to In Progress
- % Done changed from 0 to 10
- Feature Branch set to bugfix/14602-refresh-Tor-Browser-AppArmor-profile
Resolved conflicts, pushed to our torbrowser-launcher.git, refreshed patch => testing locally.
#3 Updated by intrigeri 2017-09-05 10:24:12
- Assignee changed from intrigeri to anonym
- % Done changed from 10 to 20
- QA Check set to Ready for QA
This branch fixes the build, so it’s an obvious incremental improvement over the current state of things => please review’n’merge. But don’t close the ticket immediately as I want to do a full test suite run (many Tor Browser tests are flagged as fragile) to ensure we don’t regress at runtime.
#4 Updated by intrigeri 2017-09-05 14:59:00
A full test suite run on my own Jenkins shows only 2 failures: “FindFailed: can not find TorBrowserBlockedVideo.png” (expected, see dedicated ticket) and “The page was not printed to /home/amnesia/Persistent/Tor Browser/output.pdf” in the “The persistent Tor Browser directory is usable” scenario. I’ll try to reproduce the latter manually, but this shouldn’t prevent you from fixing the devel branch by merging this one.
#5 Updated by intrigeri 2017-09-05 15:20:40
- % Done changed from 20 to 50
intrigeri wrote:
> “The page was not printed to /home/amnesia/Persistent/Tor Browser/output.pdf” in the “The persistent Tor Browser directory is usable” scenario. I’ll try to reproduce the latter manually, […]
It works when testing manually. On the failure video I see that the homepage text + CSS was loaded but many images are still missing. I suspect that this is what prevents the printing to work as expected. So I’m happy with my test results, you can flag this as “Fix committed” once merged :)
#6 Updated by anonym 2017-09-06 09:52:27
- Status changed from In Progress to Fix committed
- Assignee deleted (
anonym) - % Done changed from 50 to 100
- QA Check changed from Ready for QA to Pass
I built locally and just made sure that the browser starts and has the AppArmor profile enforced.
#7 Updated by anonym 2017-09-28 18:48:36
- Status changed from Fix committed to Resolved