Feature #14556

Show a suspend to RAM button in the status menu

Added by segfault 2017-08-30 10:49:35 . Updated 2019-05-06 18:15:38 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.13.2
Start date:
2017-08-30
Due date:
% Done:

0%

Feature Branch:
feature/14556-show-suspend-button
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

We might want to require setting up the screen locker (Feature #5684) before suspending to RAM.

Subtasks

Related issues

Related to Tails - Feature #5684: Screen locker Resolved 2014-12-03
Related to Tails - Bug #11729: Emergency shutdown triggered after resuming from suspend Resolved 2016-08-26
Related to Tails - Bug #11052: Do not suspend when closing lid Rejected 2016-05-03
Related to Tails - Bug #15640: Suspend button shown when screen is locked Resolved 2018-06-08

History

#1 Updated by segfault 2017-08-30 10:49:51

#2 Updated by intrigeri 2017-08-30 13:00:37

  • related to Bug #11729: Emergency shutdown triggered after resuming from suspend added

#3 Updated by intrigeri 2017-08-30 13:01:07

  • related to Bug #11052: Do not suspend when closing lid added

#4 Updated by intrigeri 2017-09-28 12:05:27

  • Target version changed from 2018 to 2019

(as per updated roadmap)

#5 Updated by Gaff 2018-06-08 16:48:43

Is suspending not a security risk? A suspended machine is at risk of being hacked - whereas a powered down machine is not. A user might assume his machine is powered down and thus safe from hacking.

(See also: Bug #15640)

#6 Updated by intrigeri 2018-06-10 10:05:49

  • related to Bug #15640: Suspend button shown when screen is locked added

#7 Updated by segfault 2019-03-23 12:22:12

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|f79d0cf6261c30dddbd69bbc26f76f8e049293d2.

#8 Updated by intrigeri 2019-03-23 12:31:50

  • Target version deleted (2019)

(Looks like this one was missed when we updated Redmine after finalizing our 2019 roadmap.)

#9 Updated by segfault 2019-03-28 22:46:39

  • Feature Branch set to feature/14556-show-suspend-button

I changed the extension to display the suspend button, which I think we can safely do now since there seems to be a fix for Bug #11729 (implemented on the same branch).

While at it, I also changed that now the poweroff and reboot buttons are still displayed when the screen is locked, for easier shutdown as a security feature, as suggested by sajolida in Bug #15640#note-7.

#10 Updated by segfault 2019-03-28 22:46:50

  • Assignee deleted (segfault)
  • QA Check set to Ready for QA

#11 Updated by intrigeri 2019-04-03 09:41:05

  • Assignee set to intrigeri
  • Target version set to Tails_3.14

#12 Updated by intrigeri 2019-04-04 07:28:10

  • Assignee changed from intrigeri to segfault
  • QA Check changed from Ready for QA to Dev Needed

Great work! Only one comment: the order of the poweroff and restart buttons has been reversed. I could not find any explanation for this change in the Git log. Was this done on purpose? I have no strong opinion on this topic myself but I suggest getting sajolida’s input (before/after screenshots would help).

Code review passes and it works fine during my tests.

@segfault, sending back to your plate for the above.

#13 Updated by segfault 2019-04-04 11:14:17

  • QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:
> Great work! Only one comment: the order of the poweroff and restart buttons has been reversed. I could not find any explanation for this change in the Git log. Was this done on purpose?

No, that was not intended. I fixed it on the the branch.

#14 Updated by intrigeri 2019-04-04 12:30:10

  • Assignee changed from segfault to intrigeri

#15 Updated by intrigeri 2019-04-04 13:07:26

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|8f4bf911c03b195ff615d2c47b45e9a2f3779d62.

#16 Updated by intrigeri 2019-04-04 13:08:24

  • Assignee deleted (intrigeri)
  • % Done changed from 100 to 0
  • QA Check changed from Ready for QA to Pass

#17 Updated by sajolida 2019-04-17 19:02:59

@segfault: If I’m on a desktop and suspend to RAM, how do I wake up? Pressing any key? If I’m on a laptop and click the suspend to RAM option by mistake, how do I wake up?

#18 Updated by segfault 2019-04-18 21:40:43

sajolida wrote:
> @segfault: If I’m on a desktop and suspend to RAM, how do I wake up? Pressing any key? If I’m on a laptop and click the suspend to RAM option by mistake, how do I wake up?

@sajolida: I guess it depends on the hardware/firmware. Pressing any key might work, pressing the power button should probably always work.

#19 Updated by sajolida 2019-04-30 18:33:29

Pressing the power button, yes!

#20 Updated by intrigeri 2019-05-05 08:23:55

  • Target version changed from Tails_3.14 to Tails_3.13.2

#21 Updated by anonym 2019-05-06 15:00:47

  • Status changed from Fix committed to Resolved

#22 Updated by anonym 2019-05-06 15:03:14

  • Target version changed from Tails_3.13.2 to Tails_3.14

#23 Updated by intrigeri 2019-05-06 18:15:38

  • Target version changed from Tails_3.14 to Tails_3.13.2