Feature #14471

Write tests for VeraCrypt support in GNOME Disks

Added by segfault 2017-08-28 15:17:16 . Updated 2018-12-16 13:39:45 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Test suite
Target version:
Tails_3.11
Start date:
2017-08-28
Due date:
% Done:

100%

Feature Branch:
test/14471-veracrypt
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
299

Description

This is part of “A.3 Write automated tests”.

Subtasks

Related issues

Related to Tails - Feature #15946: Extend VeraCrypt automated tests with PIM Resolved 2018-09-12
Blocked by Tails - Feature #14469: Write Gherkin scenarios for VeraCrypt automated tests Resolved 2017-08-28
Blocked by Tails - Feature #15238: Iteration 1: Write tests for unlocking VeraCrypt partitions in GNOME Resolved 2018-01-25
Blocked by Tails - Feature #15239: Iteration 2: Write tests for unlocking VeraCrypt file containers in GNOME Resolved 2018-01-25

History

#1 Updated by intrigeri 2017-08-28 16:49:37

  • Category set to Test suite
  • Type of work changed from Test to Code

#2 Updated by intrigeri 2017-09-29 17:17:26

  • blocked by Feature #14469: Write Gherkin scenarios for VeraCrypt automated tests added

#3 Updated by intrigeri 2017-09-29 17:17:48

  • Description updated

#4 Updated by segfault 2018-01-25 12:27:20

  • Target version changed from Tails_3.7 to Tails_3.9

Will be resolved by Feature #15238, Feature #15239, and Feature #15240.

#5 Updated by anonym 2018-02-26 15:23:49

  • blocks deleted (Feature #14469: Write Gherkin scenarios for VeraCrypt automated tests)

#6 Updated by anonym 2018-02-26 15:25:42

  • blocked by Feature #14469: Write Gherkin scenarios for VeraCrypt automated tests added

#7 Updated by intrigeri 2018-06-03 12:58:16

  • blocked by Feature #15238: Iteration 1: Write tests for unlocking VeraCrypt partitions in GNOME added

#8 Updated by intrigeri 2018-06-03 12:58:24

  • blocked by Feature #15239: Iteration 2: Write tests for unlocking VeraCrypt file containers in GNOME added

#9 Updated by intrigeri 2018-06-03 13:03:32

Reparenting as this is not part of A.5 which is done.

#10 Updated by intrigeri 2018-06-26 17:15:05

  • Assignee changed from anonym to intrigeri
  • Target version changed from Tails_3.9 to Tails_3.10.1

#12 Updated by intrigeri 2018-09-05 17:28:04

  • Priority changed from Normal to Elevated

#13 Updated by intrigeri 2018-09-12 08:47:31

  • Feature Branch set to test/14471-veracrypt

#14 Updated by intrigeri 2018-09-12 15:38:05

  • related to Feature #15946: Extend VeraCrypt automated tests with PIM added

#15 Updated by intrigeri 2018-09-13 18:30:12

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 20

Done for USB sticks, let’s see what Jenkins thinks.

#16 Updated by intrigeri 2018-09-13 20:15:41

  • % Done changed from 20 to 30
  • QA Check set to Ready for QA

Done for file containers as well.

#17 Updated by intrigeri 2018-09-15 06:55:50

  • % Done changed from 30 to 50

All this now works very nicely locally, let’s see how it fares on Jenkins.

#18 Updated by intrigeri 2018-09-18 14:43:01

  • Assignee changed from intrigeri to CyrilBrulebois

#19 Updated by intrigeri 2018-09-18 14:51:40

Note: please take the Gherkin (features/veracrypt.feature) as granted, as it’ll be reviewed by segfault on Feature #14469.

#20 Updated by intrigeri 2018-10-15 11:32:23

FTR segfault deemed the Gherkin good enough. Bonus points if we can merge this by the end of the month (when the sponsor contract ends).

#21 Updated by intrigeri 2018-10-24 17:03:39

  • Target version changed from Tails_3.10.1 to Tails_3.11

#22 Updated by CyrilBrulebois 2018-10-31 20:44:59

I’m no Gherkin expert (yet?), but that looks reasonable to me as well.

It seems my setup might not meet the exact requirements for running the test suite at the moment, so I’m not able to double check it runs smoothly locally. (I’ll try to get the test suite up and running soon though.)

#23 Updated by intrigeri 2018-11-01 08:00:14

The tests pass on Jenkins: https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_test-14471-veracrypt/ (for example, https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_test-14471-veracrypt/1/cucumberTestReport/using-veracrypt-encrypted-volumes/).

Thanks for the initial review. Can you please clarify whether you’ve completed the code review and if yes, whether it’s good enough for merging in your opinion?

#24 Updated by CyrilBrulebois 2018-11-01 13:46:39

  • QA Check changed from Ready for QA to Pass

Yes, I’ve checked the entire patch series, and merging looks reasonable. Setting QA Check: Pass accordingly.

#25 Updated by intrigeri 2018-11-01 14:22:52

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:tails|d01d4b2b1cf60fac8d33c19a82448b6bd49ca403.

#26 Updated by intrigeri 2018-11-01 14:23:40

  • Assignee deleted (CyrilBrulebois)

Thanks, merged! Will email tails-dev@ about the setup changes.

#27 Updated by CyrilBrulebois 2018-12-16 13:39:45

  • Status changed from Fix committed to Resolved