Feature #13602

OpenPGP Applet: rewrite key selection interface

Added by nodens 2017-08-08 17:50:56 . Updated 2018-02-26 08:32:27 .

Status:
Duplicate
Priority:
Normal
Assignee:
nodens
Category:
Target version:
Start date:
2017-08-08
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
OpenPGP Applet
Deliverable for:

Description

The public key selection interface in OpenPGP Applet currently uses Gtk3::SimpleList.

The problem is, since it’s a simple list we can’t display the ids as subentries, and we use a tooltip for that.
Also, it’s buggy since the port to Gtk3 (Bug #12190).

By using the complete Gtk::Treeview implementation, we could:

  • fix the bug
  • display the ids as subentries of each public key
  • add a search box

Ideally, we would mimic Seahorse’s interface. The first implementation doesn’t have to be as neat, though.

Subtasks

Related issues

Related to Tails - Bug #12190: OpenPGP applet public key list includes 21 empty key lines Duplicate 2017-01-30
Related to Tails - Bug #14808: OpenPGP Applet should display key creation time instead of key ID Duplicate 2017-10-07

History

#1 Updated by nodens 2017-08-08 17:51:33

  • related to Bug #12190: OpenPGP applet public key list includes 21 empty key lines added

#2 Updated by intrigeri 2017-08-09 15:06:06

IMO at this point we should take a step back and check if the cost/benefit is worth it, compared to delegating public key encryption to seahorse-tool.

#3 Updated by nodens 2017-10-07 09:44:22

#4 Updated by nodens 2017-10-07 11:07:59

  • related to Bug #14808: OpenPGP Applet should display key creation time instead of key ID added

#5 Updated by nodens 2017-10-09 22:01:40

intrigeri wrote:
> IMO at this point we should take a step back and check if the cost/benefit is worth it, compared to delegating public key encryption to seahorse-tool.

We could (delegate pubkey encryption to seahorse-tool), but there are a few issues in my book:

  • we have to use a temporary file, seahorse-tool doesn’t read from stdin or write to stdout. Files are encrypted as <filename.pgp>,
  • encryption creates only binary format file, there is no way to armor it,
  • decryption is the same: it takes the file and write a new file, named <encryptedfile minus the last 4 chars>. Without checking if there is an existing file of the same name, by the way
  • on my laptop, with my (admitedly long) public keyring, it takes 20-30 seconds to display the key selection interface (less than 5 seconds currently with openpgp-applet)
  • we don’t have any way to see alternate identities or fingerprint in the seahorse-tool key-

While we may work around some of those issues, I feel it would be best to rewrite the key selection interface as depicted in the issue description (and I’m willing to work on it).

#6 Updated by Anonymous 2018-01-15 16:07:04

@nodens: do you want to set yourself a target version for this?

#7 Updated by nodens 2018-02-25 18:55:02

  • Status changed from Confirmed to Resolved

Hi,

OpenPGP applet is moving to its new home on https://salsa.debian.org/openpgp-applet-team/openpgp-applet

This issue has been duplicated upstream: https://salsa.debian.org/openpgp-applet-team/openpgp-applet/issues/8

I’m closing this one. Feel free to comment on the upstream link!

You will need an account on Salsa. If you don’t have one already, you can create one on https://signup.salsa.debian.org/.

Cheers!

#8 Updated by intrigeri 2018-02-26 08:32:27

  • Status changed from Resolved to Duplicate