Bug #13198

About menu of WhisperBack doesn't show the logo

Added by xin 2017-06-28 08:53:27 . Updated 2018-05-10 11:06:13 .

Status:
Resolved
Priority:
Low
Assignee:
Category:
Target version:
Start date:
2017-06-28
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
1
Affected tool:
WhisperBack
Deliverable for:

Description

In some gtk softwares, about menu show the logo.
In WhisperBack, it show a little grey image instead of the logo.

Test in 3.0.


Files


Subtasks


Related issues

Blocked by Tails - Bug #15440: Missing WhisperBack 1.7.14 in Git Resolved 2018-03-22

History

#1 Updated by intrigeri 2017-06-28 08:57:49

  • Status changed from New to Confirmed

This would be a good task for a new contributor :)

The code lives there: https://git-tails.immerda.ch/whisperback/

#2 Updated by xin 2017-06-28 09:09:13

> This would be a good task for a new contributor :)

Should set to Easy ?

#3 Updated by intrigeri 2017-06-28 09:25:03

  • Starter set to Yes

Yes! (I tried in my last email but apparently I got the syntax wrong.)

#4 Updated by intrigeri 2017-06-28 09:25:12

  • Subject changed from About menu of WhisperBack don't show the logo to About menu of WhisperBack doesn't show the logo

#5 Updated by sascha.markus@gmail.com 2018-03-22 08:54:23

Here is a patch for this issue.
Cheers
Sascha

#6 Updated by intrigeri 2018-03-22 09:58:14

  • Assignee set to intrigeri
  • Target version set to Tails_3.7
  • QA Check set to Ready for QA

#7 Updated by intrigeri 2018-03-22 12:03:02

  • blocked by Bug #15440: Missing WhisperBack 1.7.14 in Git added

#8 Updated by intrigeri 2018-03-22 12:04:12

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 60

Code review passes, thanks! I’ll test and merge once bertagaz pushes some missing bits to the Git repo (Bug #15440).

#9 Updated by intrigeri 2018-04-14 07:31:51

  • % Done changed from 60 to 90
  • QA Check changed from Ready for QA to Pass

Quick testing works => I’ll merge this once Bug #15440 is done.

#10 Updated by intrigeri 2018-05-07 12:36:20

  • Assignee changed from intrigeri to bertagaz

Merged, will be fixed once bertagaz releases a new WhisperBack!

#11 Updated by bertagaz 2018-05-10 11:06:13

  • Status changed from In Progress to Resolved
  • Assignee deleted (bertagaz)
  • % Done changed from 90 to 100

intrigeri wrote:
> Merged, will be fixed once bertagaz releases a new WhisperBack!

It’s been released!