Bug #12909

/var/cache/cracklib/src-dicts not reproducible

Added by lamby 2017-06-23 08:34:59 . Updated 2017-08-09 12:38:45 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Build system
Target version:
Start date:
2017-06-23
Due date:
% Done:

100%

Feature Branch:
bugfix/12909-reproducible-cracklib2-dicts
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
289

Description

​/​usr/​share/​dict/​README.​select-​wordlist·​/​usr/​share/​dict/​cracklib-​small·​/​usr/​share/​dict/​american-​english

vs

·​/​usr/​share/​dict/​american-​english·​/​usr/​share/​dict/​README.​select-​wordlist·​/​usr/​share/​dict/​cracklib-​small

via https://labs.riseup.net/code/issues/12738#note-1


Subtasks


History

#2 Updated by intrigeri 2017-06-23 10:46:35

  • Deliverable for set to 289

#3 Updated by intrigeri 2017-07-18 13:04:10

  • Status changed from Confirmed to In Progress
  • Assignee changed from lamby to anonym
  • % Done changed from 0 to 30
  • Type of work changed from Research to Code

It looks like next step is: anonym applies this patch and uploads a package to our custom APT repo.

#4 Updated by intrigeri 2017-07-20 11:40:15

#5 Updated by anonym 2017-08-04 20:21:41

  • Assignee changed from anonym to bertagaz
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/12909-reproducible-cracklib2-dicts

Let’s see what Jenkins thinks: https://jenkins.tails.boum.org/job/test_Tails_ISO_bugfix-12909-reproducible-cracklib2-dicts/

bert, it’s doubtful I’ll have time to look at the results before you start building Tails 3.1 tomorrow. Would you consider review’n’merging this branch any way if you get the time?

#6 Updated by bertagaz 2017-08-05 10:07:47

  • Status changed from In Progress to Fix committed
  • Assignee deleted (bertagaz)
  • % Done changed from 30 to 100
  • QA Check changed from Ready for QA to Pass

anonym wrote:
> Let’s see what Jenkins thinks: https://jenkins.tails.boum.org/job/test_Tails_ISO_bugfix-12909-reproducible-cracklib2-dicts/
>
> bert, it’s doubtful I’ll have time to look at the results before you start building Tails 3.1 tomorrow. Would you consider review’n’merging this branch any way if you get the time?

I did, tests pass, ISO is reproducible, so I’ve merged it for 3.1.

#7 Updated by lamby 2017-08-05 11:32:55

bertagaz wrote:

> I did, tests pass, ISO is reproducible

Sorry for “noise”, but \o/ \o/ \o/ \o/ \o/

#8 Updated by Anonymous 2017-08-05 11:53:35

\o/ amazing!

#9 Updated by bertagaz 2017-08-09 12:38:45

  • Status changed from Fix committed to Resolved