Tails

#1 Updated by intrigeri 2017-06-04 16:40:58

• related to Bug #12547: Selecting Language "English - x" results in the wrong keyboard layout for many values of x added

#2 Updated by alant 2017-06-04 17:03:07

• Status changed from Confirmed to In Progress
• Feature Branch set to bugfix/12638-wrong-language-to-keyboard

This should be fixed by the bugfix/12638-wrong-language-to-keyboard branch.

#3 Updated by alant 2017-06-04 17:03:27

• Assignee changed from alant to intrigeri
• QA Check set to Ready for QA

#4 Updated by intrigeri 2017-06-05 09:56:19

• Target version changed from Tails_3.1 to Tails_3.0

I’ll take a look on Wednesday and check the risk/benefit ratio of merging this in time for 3.0.

#5 Updated by intrigeri 2017-06-07 13:51:10

• Assignee changed from intrigeri to alant
• % Done changed from 0 to 10
• QA Check changed from Ready for QA to Info Needed

I’m open to merging something to fix this bug if it’s ready in time for the 3.0 hard freeze (currently June 9, 15:00 CEST; https://tails.boum.org/contribute/calendar/ might be updated later). But at this very late stage, for bugs whose impact is very limited like this one, I would like:

• targetted fixes only, rather than branches that mix refactoring wit bug fixes;
• to know what kind of testing has been done already on the proposed code.

So:

• I don’t understand what’s the purpose of commit c711741e409209cb7b5010c778849a6ccbed2c1d. It looks like a mere refactoring, but the commit message suggests it adds support for something that I don’t see used anywhere, so I’m wondering.
• Do we need commit fff9214f0837e2db2aa05a1d9c9bb33f06580012 to fix this bug, or is it merely refactoring?
• What did you already test yourself?

If I don’t get answers in time, I’ll postpone to 3.1 and bertagaz can review the whole thing at once :)

#6 Updated by intrigeri 2017-06-09 20:19:17

• Assignee changed from alant to bertagaz
• Target version changed from Tails_3.0 to Tails_3.1
• QA Check changed from Info Needed to Ready for QA

3.0 is frozen. Perhaps bertagaz will want the non-targetted-fixes bits as part of 3.1, who knows.

#7 Updated by intrigeri 2017-06-12 15:28:27

• Assignee changed from bertagaz to alant
• QA Check changed from Ready for QA to Dev Needed

During the 3.0 manual testing session today, we noticed a similar problem: the effect is the same (it matches the title of this ticket), but the root cause is different. If you prefer I’ll move this report to a dedicated ticket.

So, here’s what happens: when selecting Arabic (Egypt), a US keyboard layout is picked.

_layouts_for_language: got 11 layouts for ar
set_default: Language ar layouts: ['dz+ar', 'iq', 'ara', 'ara+buckwalter', 'ara+azerty_digits', 'ara+qwerty_digits', 'ara+digits', 'ara+mac', 'pk+ara', 'ara+azerty', 'ara+qwerty']
_layouts_for_country: got 0 layouts for EG
set_default: Country EG layouts: []
set_default: Intersection of language ar and country EG: set()
set_default: Empty intersection of language and country, filter by country EG only: []
set_default: List still empty, filter by language ar only: []
set_default: List still empty, use all language ar layouts: ['dz+ar', 'iq', 'ara', 'ara+buckwalter', 'ara+azerty_digits', 'ara+qwerty_digits', 'ara+digits', 'ara+mac', 'pk+ara', 'ara+azerty', 'ara+qwerty']
_filter_layouts: Filter by variant: ['iq', 'ara']
_filter_layouts: Filter by country EG: []
_filter_layouts: Filter by language ar: []
set_default: Still not 1 layouts. Try again using all country EG layouts: []
set_default: Using us as fallback default layout

Same problem e.g. for Arabic (Saudi Arabia), Arabic (Sudan), Arabic (Kuwait).

I’m fully aware that’s how the algorithm is supposed to work, but from a user-centric perspective, well, it doesn’t quite do the right thing :) Maybe it’s time to start using a hard-coded mapping (taken from some Linux distro’s installer?), that we can use when the clever algorithm fails. Or we can perhaps instead add another heuristic: when we find more than one candidate, but no exact match, before falling back to US we can look among candidate layouts for those whose name starts with the language name: in this case, ‘ara’ would be selected because it’s the only candidate whose name starts with ‘ar’. What do you think?

#8 Updated by intrigeri 2017-06-28 16:56:55

• Target version deleted (Tails_3.1)

This was reported only once since the 3.0 release, so at the help desk / foundations team meeting today, we deemed this ticket as low priority => dropping target version.

#20 Updated by intrigeri 2018-01-09 15:51:04

• has duplicate Bug #15161: Selecting Arabic language in Greeter results in English keyboard layout added

#22 Updated by Anonymous 2018-01-15 16:23:17

• related to Bug #12598: Afghani keyboard selected in Greeter if typing fast added

#23 Updated by alant 2018-01-15 22:33:22

• Assignee deleted (alant)
• QA Check changed from Dev Needed to Info Needed

u wrote:
> Any news on this one? Maybe for 3.6?

It’s unclear to me what should be done. This ticket has a branch proposed, then questions about it, then various other issues discussed. Do you want me to reply to https://labs.riseup.net/code/issues/12638#note-5 ?

#24 Updated by intrigeri 2018-01-16 07:37:18

• Assignee set to alant
• QA Check changed from Info Needed to Dev Needed

alant wrote:
> It’s unclear to me what should be done. This ticket has a branch proposed, then questions about it, then various other issues discussed. Do you want me to reply to https://labs.riseup.net/code/issues/12638#note-5 ?

Yes, please address the questions raised when this branch was reviewed :)

#25 Updated by sajolida 2019-01-22 18:23:58

• related to Feature #14544: Spend software developer time on smallish UX improvements added

#26 Updated by sajolida 2019-01-22 18:25:15

• Parent task deleted (Feature #11643)

#27 Updated by intrigeri 2019-02-06 16:27:51

• blocks Feature #15507: Core work 2019Q1: Foundations Team added

#28 Updated by intrigeri 2019-02-06 16:28:37

• Assignee deleted (alant)

#29 Updated by intrigeri 2019-02-22 14:25:09

• related to Bug #16481: Tails in Indonesian starts with Arabic keyboard (and rtl) added

#30 Updated by intrigeri 2019-03-08 15:31:01

• Status changed from In Progress to Confirmed

#31 Updated by intrigeri 2019-03-12 16:10:13

• blocks Feature #16209: Core work: Foundations Team added

#32 Updated by intrigeri 2019-03-12 16:10:16

• blocked by deleted (Feature #15507: Core work 2019Q1: Foundations Team)

#33 Updated by intrigeri 2019-08-10 09:31:02

• has duplicate Bug #16838: Selecting Arabic language in Greeter results in English (US) keyboard added

#36 Updated by intrigeri 2019-09-30 07:31:36

• Description updated

#37 Updated by intrigeri 2020-04-15 06:02:11

• Affected tool changed from Greeter to Welcome Screen