Bug #12621

The 'Tor is ready' step fails when any systemd service fails

Added by anonym about 8 years ago. Updated about 7 years ago.

Status:
Confirmed
Priority:
Normal
Assignee:
anonym
Category:
Test suite
Target version:
Start date:
2017-05-31
Due date:
% Done:

0%

Feature Branch:
Type of work:
Discuss
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Extracted from Bug #12617:

intrigeri wrote:
> anonym wrote:
> > [Any systemd service failing] breaks all automated tests using Tor, since the Tor is ready step runs systemctl is-system-running. The placement of that check in that step is my second issue: it doesn’t belong. It should be moved into a dedicated step, run in a scenario about the health of the system. A failure would then in itself immediately signal something quite descriptive about the actual failure, instead of falsely signaling that something about little-t tor is utterly broken, blocking a huge part of the test suite.
>
> Well, IMO it’s good that we run systemctl is-system-running as often as we can, before testing other stuff, to identify issues as early as possible. IIRC we can’t run it for offline scenarios since this check will fail if Tor hasn’t started or bootstrapped. But I agree the current way this is implemented gives suboptimal feedback. Perhaps renaming the “Tor is ready” step to describe more accurately what we test in it would help.

Files

02_04_22_Creating_and_using_a_Jessie-area_persistent_NetworkManager_connection.journal (388495 B) bertagaz, about 8 years ago
01_38_29_Getting_a_DHCP_lease_with_the_default_NetworkManager_connection.journal (421550 B) bertagaz, about 8 years ago

Subtasks

History

#1 Updated by anonym about 8 years ago

  • Description updated

#2 Updated by anonym about 8 years ago

  • blocks Feature #13239: Core work 2017Q3: Test suite maintenance added

#3 Updated by anonym about 8 years ago

  • Target version changed from Tails_3.1 to Tails_3.2

#7 Updated by intrigeri about 8 years ago

  • Target version changed from Tails_3.2 to Tails_3.3

#8 Updated by intrigeri about 8 years ago

  • blocks Feature #13240: Core work 2017Q4: Test suite maintenance added

#9 Updated by intrigeri about 8 years ago

  • blocked by deleted (Feature #13239: Core work 2017Q3: Test suite maintenance)

#10 Updated by intrigeri about 7 years ago

  • Target version changed from Tails_3.3 to Tails_3.5

#11 Updated by intrigeri about 7 years ago

  • Target version deleted (Tails_3.5)

#12 Updated by intrigeri about 7 years ago

  • blocked by deleted (Feature #13240: Core work 2017Q4: Test suite maintenance)