Bug #12620

/usr/local/lib/tor-browser/omni.ja embeds build timestamp

Added by intrigeri 2017-05-31 09:44:11 . Updated 2017-06-12 16:07:11 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.0
Start date:
2017-05-31
Due date:
% Done:

100%

Feature Branch:
bugfix/12620-omni.ja-reproducibility-fix
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
289

Description

I guess this reproducibility regression was caused by the hacks we had to do for Tor Browser 7.0.

Subtasks

History

#1 Updated by anonym 2017-05-31 18:15:23

  • Status changed from Confirmed to In Progress
  • Assignee changed from anonym to intrigeri
  • Target version set to Tails_3.0
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/12620-omni.ja-reproducibility-fix

The feature branch fixes this for me locally. Please review’n’merge into testing!

#2 Updated by intrigeri 2017-06-01 07:10:36

  • % Done changed from 50 to 60

I’m not quite sure why we need strip_nondeterminism_wrapper since we already set the correct timestamp on each modified file before including it in omni.ja, but whatever: code review passes! Set up https://jenkins.tails.boum.org/job/reproducibly_build_Tails_ISO_bugfix-12620-omni.ja-reproducibility-fix/ to check reproducibility.

#4 Updated by intrigeri 2017-06-01 09:33:01

  • Status changed from In Progress to Fix committed
  • % Done changed from 60 to 100

Applied in changeset commit:7c0e5aed243bcf29334be63a9dd9d813793b71e4.

#5 Updated by intrigeri 2017-06-01 09:34:54

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#6 Updated by intrigeri 2017-06-12 16:07:11

  • Status changed from Fix committed to Resolved