Bug #12610

Install OnionShare from sid to fix the build of the devel branch

Added by intrigeri 2017-05-27 08:05:15 . Updated 2017-06-12 16:11:25 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Start date:
2017-05-27
Due date:
% Done:

100%

Feature Branch:
bugfix/12610-onionshare-from-sid
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

We’ve got OnionShare removed from testing, so devel FTBFS as the package cannot be installed anymore.


Subtasks


Related issues

Blocks Tails - Bug #12609: Bump APT snapshots serial for 3.0: 2017-06-09 Resolved 2017-05-27

History

#1 Updated by intrigeri 2017-05-27 08:06:45

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • Feature Branch set to bugfix/12610-onionshare-from-sid

#2 Updated by intrigeri 2017-05-27 11:14:39

  • Assignee changed from intrigeri to anonym
  • % Done changed from 10 to 50
  • QA Check set to Ready for QA

The expected version is installed: https://jenkins.tails.boum.org/job/build_Tails_ISO_bugfix-12610-onionshare-from-sid/lastSuccessfulBuild/artifact/latest.iso.packages/*view*/ (i.e. the same one as on testing branch).

#3 Updated by intrigeri 2017-05-27 11:14:58

  • blocks Bug #12609: Bump APT snapshots serial for 3.0: 2017-06-09 added

#4 Updated by anonym 2017-05-30 08:31:04

  • Status changed from In Progress to Fix committed
  • Assignee changed from anonym to intrigeri
  • % Done changed from 50 to 100

I had to follow up with these commits:

commit f9941c1c778d6869ac6f62de437aceb5b1393c47
Author: anonym <anonym@riseup.net>
Date:   Mon May 29 20:34:33 2017 +0200

    Fetch the torbrowser-launcher sources from Debian sid.

    It's been removed from Debian testing (along with OnionShare, refs: <del><a class='issue tracker-1 status-3 priority-5 priority-default closed child' href='/code/issues/12610' title='Install OnionShare from sid to fix the build of the devel branch'>Bug #12610</a></del>).

commit fc8d513540b414d4684a87de4e29cb0ec8e34ba0
Author: anonym <anonym@riseup.net>
Date:   Mon May 29 18:28:36 2017 +0200

    Drop now irrelevant build hook causing FTBFS.

    ... due to torbrowser-launcher not being installed any more at this
    stage, resulting in trying to create a fake pacjage wutg an invalid
    version number. OnionShare stopped depending on
    torbrowser-launcher (refs: <del><a class='issue tracker-1 status-3 priority-5 priority-default closed child' href='/code/issues/12610' title='Install OnionShare from sid to fix the build of the devel branch'>Bug #12610</a></del>) so we don't need to satisy this
    dependency with a fake package any more.


Please have a look and make sure they are sane!

#5 Updated by intrigeri 2017-05-30 09:00:20

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

Looks OK to me, modulo quite a few obvious typos in the commit message; please proof-read such stuff a bit carefully when you push straight to a base branch without review :) Anyway, thanks!

#6 Updated by anonym 2017-05-30 13:25:05

  • Status changed from Fix committed to In Progress

Applied in changeset commit:fc8d513540b414d4684a87de4e29cb0ec8e34ba0.

#7 Updated by intrigeri 2017-06-01 10:27:37

  • Status changed from In Progress to Fix committed

#8 Updated by intrigeri 2017-06-12 16:11:25

  • Status changed from Fix committed to Resolved