Bug #12573

YouTube is the default search engine in the Unsafe Browser of 3.0~rc1

Added by spriver 2017-05-20 17:27:41 . Updated 2017-06-12 16:07:12 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.0
Start date:
2017-05-20
Due date:
% Done:

100%

Feature Branch:
bugfix/12540-disable-search-in-unsafe-browser
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Unsafe Browser
Deliverable for:

Description

YouTube is the default search engine in the Unsafe Browser of 3.0~rc1.
Typing in the address bar or the search field will search in YouTube instead of Google.

Subtasks

History

#1 Updated by spriver 2017-05-21 14:31:08

I fuzzed around with the prefs.js of the Unsafe Browser, it seems that the two settings

"user_pref("browser.search.defaultenginename", "Google"); user_pref("browser.search.selectedEngine", "Google");"

don’t change anything (at least with my tests done with changing the value to Bing, Twitter, etc).

#2 Updated by spriver 2017-05-21 15:17:02

Apparently the available search engines and settings for search are now stored in the (compressed) file search.json.mozlz4 (for guidance for decompression/compression to/from a plain text .json read http://forums.mozillazine.org/viewtopic.php?f=23&t=3023201&p=14708969).

It seems that the value (in the uncompressed .json) for changing the default search engine is the parameter "current":"".
We don’t ship this file for the Unsafe Browser, maybe shipping such a file solves this problem, but simply copying the search.json.mozlz4 from .tor-browser/profile.default/ into /usr/share/tails/chroot-browsers/unsafe-browser/ won’t do the trick (at least on a live system for testing purposes).

#3 Updated by intrigeri 2017-05-27 08:26:48

  • Affected tool set to Unsafe Browser

That’s a regression, but I’m not setting priority >> normal as it doesn’t affect the supported use case of the Unsafe Browser => feel free to postpone, and focus on other matters.

#4 Updated by intrigeri 2017-05-31 11:51:03

I suggest we simply hide the search box in the Unsafe Browser, since it’s not needed for the intended use case. And perhaps we could do Feature #12540 at the same time, for consistency.

#5 Updated by anonym 2017-05-31 13:14:40

  • Status changed from Confirmed to In Progress

Applied in changeset commit:d134e8647beb253c658aca7b24e0fdd25b988863.

#6 Updated by anonym 2017-06-01 00:49:25

  • Assignee changed from anonym to intrigeri
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/12540-disable-search-in-unsafe-browser

intrigeri wrote:
> I suggest we simply hide the search box in the Unsafe Browser, since it’s not needed for the intended use case. And perhaps we could do Feature #12540 at the same time, for consistency.

Sounds perfect to me! Please review’n’merge into testing!

#7 Updated by intrigeri 2017-06-01 07:31:43

Added commit:b896d7f7051b76ec92aec8c212fc470b4de8febe on top so we don’t keep an obsolete manual test around; this will address Feature #10253.

#8 Updated by intrigeri 2017-06-01 07:32:43

Code review passes, will now build & test.

#9 Updated by intrigeri 2017-06-01 08:38:43

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:dd35289e03b0b2e7c34e82b72bae16579e0712a8.

#10 Updated by intrigeri 2017-06-01 08:40:04

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#11 Updated by intrigeri 2017-06-12 16:07:12

  • Status changed from Fix committed to Resolved