Bug #12561
The persistent Tor Browser directory and the GNOME bookmarks for persistence are not always created
100%
Description
I’ve noticed that on feature/stretch-unfrozen but forgot about it and indirectly did Feature #12554 (by merging a branch based on feature/stretch-unfrozen). I at least want to investigate for 3.0~rc1 and try to come up with a fix. Worst case, document on known issues and fix in 3.0 final.
Subtasks
Related issues
|
Related to Tails - |
Resolved |
History
#1 Updated by intrigeri 2017-05-18 16:26:36
- Subject changed from The persistent Tor Browser directory is not always created to The persistent Tor Browser directory and the GNOME bookmarks for persistence are not always created
#2 Updated by intrigeri 2017-05-18 16:43:28
/usr/local/lib/create-tor-browser-directories uses /usr/local/lib/tails-shell-library/tails-greeter.sh that looks in /var/lib/live/config/tails.persistence, which is copied from /var/lib/gdm3/tails.persistence in the PostLogin file shipped by Tails Greeter. I don’t think we have a guarantee that PostLogin has finished running when we start the systemd user session and run /usr/local/lib/create-tor-browser-directories. I’ll try having Tails Greeter write directly to /var/lib/live/config/tails.persistence and see if it helps.
#3 Updated by intrigeri 2017-05-18 17:01:39
- Status changed from Confirmed to In Progress
- % Done changed from 0 to 10
- Feature Branch set to bugfix/12561-persistence-config, greeter:bugfix/12561-persistence-config
#4 Updated by intrigeri 2017-05-19 12:48:06
- % Done changed from 10 to 20
My fix seems to work while testing on bare metal. Will run the corresponding automated tests locally before sending for QA.
#5 Updated by intrigeri 2017-05-19 14:20:37
- Assignee changed from intrigeri to anonym
- % Done changed from 20 to 50
- QA Check set to Ready for QA
I saw “Scenario: The persistent Tor Browser directory is usable” pass locally so I’m now confident I understood and fixed the root cause of the problem. We’ll see if it reappears.
#6 Updated by anonym 2017-05-19 18:08:31
- Status changed from In Progress to Fix committed
- Assignee deleted (
anonym) - % Done changed from 50 to 100
- QA Check changed from Ready for QA to Pass
I had this branch merged when I tested something unrelated, but I ran the The persistent Tor Browser directory is usable scenario which runs the steps:
Then the persistent Tor Browser directory exists
And there is a GNOME bookmark for the persistent Tor Browser directory
which seems to cover this. And the code looks good (a definite improvement because of reduced code complexity)! => Merged!
#7 Updated by intrigeri 2017-05-23 09:01:56
- Status changed from Fix committed to Resolved
#8 Updated by intrigeri 2019-10-01 05:40:28
- related to
Bug #17109: wrong tails.persistence path in whisperback's debugging info added