Feature #12518

Add a toggle for previous partners

Added by Anonymous about 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Fundraising
Target version:
Tails_3.2
Start date:
2017-05-05
Due date:
% Done:

100%

Feature Branch:
451f:tails/feature/12518+toggle_partners
Type of work:
Website
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

.. to the partners page.
For now, let’s leave it as is.

Subtasks

Related issues

Related to Tails - Feature #6972: Create a "Partners" page Resolved 2017-05-05
Blocks Tails - Bug #12646: Make the Partners pages translatable Resolved 2017-06-06

History

#1 Updated by emmapeel about 8 years ago

  • Status changed from New to Confirmed

#2 Updated by intrigeri about 8 years ago

  • Tracker changed from Bug to Feature
  • Category set to Fundraising

#3 Updated by Anonymous about 8 years ago

#4 Updated by Anonymous about 8 years ago

#5 Updated by Anonymous about 8 years ago

  • Status changed from Confirmed to In Progress
  • Assignee set to sajolida
  • % Done changed from 0 to 30
  • QA Check set to Ready for QA
  • Feature Branch set to 451f:tails/feature/12518+toggle_partners

Please review.

#6 Updated by Anonymous about 8 years ago

  • blocks Bug #12646: Make the Partners pages translatable added

#7 Updated by Anonymous about 8 years ago

  • Assignee changed from sajolida to intrigeri

I’m reassigning this for review to intrigeri so that we can move forward on Bug #12646.

#8 Updated by Anonymous about 8 years ago

  • Target version set to Tails_3.2

#9 Updated by intrigeri about 8 years ago

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Info Needed

Why are we using new, custom JS instead of https://ikiwiki.info/ikiwiki/directive/toggle/ as we do everywhere else on our website? I see no justification for this in the commit log, hence my question :)

#10 Updated by Anonymous about 8 years ago

I was not aware this existed.

#11 Updated by Anonymous about 8 years ago

Looks like this does not work.. I still need to find out why but the directive is simply not translated into usable HTML.

#12 Updated by Anonymous about 8 years ago

  • Assignee set to intrigeri
  • QA Check changed from Info Needed to Ready for QA

Seems like the problem was simply due to a faulty syntax.

#13 Updated by intrigeri about 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 30 to 100

Applied in changeset commit:99fa75bb231a0b14ac39083e2081bdbdbf55dd15.

#14 Updated by intrigeri about 8 years ago

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

looks nice!