Bug #12508

tails-installer icon missing

Added by dkg 2017-05-05 02:01:36 . Updated 2018-04-08 16:47:26 .

Status:
Resolved
Priority:
Low
Assignee:
kurono
Category:
Installation
Target version:
Start date:
2017-05-05
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Installer
Deliverable for:

Description

in version 3.0~beta4, i’m trying to use the tails-installer. the launcher icon is a specific tails-installer launcher. but when i’m running tails installer, its icon (in the taskbar, when i alt-tab, or in the side dock when i press the pizza key) is just a generic grey rectangle with a fold in the lower-left corner. It should have the launcher’s icon there.


Subtasks


History

#1 Updated by intrigeri 2017-05-11 09:37:41

  • Category set to Installation
  • Status changed from New to Confirmed
  • Priority changed from Normal to Low
  • Type of work changed from User interface design to Code
  • Affected tool set to Installer

> in version 3.0~beta4, i’m trying to use the tails-installer. the launcher icon is a specific tails-installer launcher. but when i’m running tails installer, its icon (in the taskbar, when i alt-tab, or in the side dock when i press the pizza key) is just a generic grey rectangle with a fold in the lower-left corner. It should have the launcher’s icon there.

To clarify: the icon for the Tails Installer launcher (/usr/bin/tails-installer-launcher, /usr/share/applications/tails-installer-launcher.desktop) is OK, but the problem dkg describes is about the icon for the Tails Installer (/usr/lib/tails_installer/tails-installer) window. I don’t know how to solve that. Perhaps adding a .desktop for the tails-installer program would be enough? But it would need to be hidden from the applications menu.

#2 Updated by dkg 2017-05-17 04:16:01

intrigeri wrote:
> To clarify: the icon for the Tails Installer launcher (/usr/bin/tails-installer-launcher, /usr/share/applications/tails-installer-launcher.desktop) is OK, but the problem dkg describes is about the icon for the Tails Installer (/usr/lib/tails_installer/tails-installer) window. I don’t know how to solve that.

I think you can just call set_icon_from_file (https://developer.gnome.org/gtk3/stable/GtkWindow.html#gtk-window-set-icon-from-file) on the TailsInstallerWindow

#3 Updated by xin 2017-06-27 11:30:53

  • Assignee set to dkg
  • QA Check set to Info Needed

I don’t have this bug in 3.0, can you see if you still have this bug in the last version?

#4 Updated by intrigeri 2017-06-27 12:14:41

  • Assignee deleted (dkg)

> I don’t have this bug in 3.0, can you see if you still have this bug in the last version?

I do see this bug in 3.0. Can you please read the description very carefully (there are a few subtleties that I initially missed myself) and try again?

#5 Updated by Anonymous 2017-06-27 13:34:25

I can see the correct icon in the taskbar when running tails-installer in Tails 3.0.
-> works in the taskbar, when doing alt-tab, AND in the side dock when i press the pizza (Pizza?) key.

However, (thanks @intrigeri!), there is no correct icone once you’ve clicked on one of the three options (upgrade, install, clone). So basically, tails-installer-launcher does provide the icon while the actual executable tails-installer does not.

This might be due to appstream or some packaging issue (the actual binary lives in /lib).

#6 Updated by Anonymous 2017-06-27 13:43:38

  • QA Check deleted (Info Needed)
  • Type of work changed from Code to Research

Assigning to kurono, apparently there could be an easy fix inside tails-installer.

#7 Updated by Anonymous 2017-06-27 13:47:16

  • Assignee set to kurono

#8 Updated by intrigeri 2017-06-27 14:02:30

  • Type of work changed from Research to Code

Next step is probably to try the one-line fix dkg suggested.

#9 Updated by intrigeri 2017-10-07 09:45:21

  • Target version set to Tails_3.3
  • QA Check set to Ready for QA

This seems to have been fixed in 3.2 with the removal of the launcher. kurono, can you please double-check?

#10 Updated by anonym 2017-11-15 11:30:53

  • Target version changed from Tails_3.3 to Tails_3.5

#11 Updated by intrigeri 2017-12-14 13:03:56

Ping?

#12 Updated by intrigeri 2017-12-23 08:41:05

  • Status changed from Confirmed to In Progress

#13 Updated by Anonymous 2018-01-15 16:36:05

  • Status changed from In Progress to Rejected

Bug not present anymore due to new version of Tails installer :) Yay.

#14 Updated by intrigeri 2018-01-15 17:04:56

  • Status changed from Rejected to Resolved

:)

#15 Updated by intrigeri 2018-04-08 16:47:26

  • QA Check deleted (Ready for QA)