Bug #12485

Upgrade Tor to 0.3.x

Added by intrigeri 2017-04-27 08:09:13 . Updated 2017-05-23 09:06:05 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.0~rc1
Start date:
2017-03-30
Due date:
% Done:

100%

Feature Branch:
feature/12485-tor-0.3.x
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

“[tor-announce] Tor 0.3.0.6 is released! (New stable series)”

I guess most of the work has already been done on our feature/tor-nightly-master branch.

Subtasks

Bug #12412: Adjust to Tor 0.3.x logging to syslog Resolved

100

Related issues

Blocks Tails - Bug #12555: Re-enable Tor's Sandbox Resolved 2017-05-17

History

#1 Updated by intrigeri 2017-05-19 07:37:46

  • Assignee changed from anonym to intrigeri
  • Feature Branch set to feature/12485-tor-0.3.x

I’m waiting for builds and tests so I’ve started working on this.

#2 Updated by intrigeri 2017-05-19 10:14:50

  • Status changed from Confirmed to In Progress

Granted freeze exception.

#3 Updated by intrigeri 2017-05-19 16:14:31

  • blocks Bug #12555: Re-enable Tor's Sandbox added

#4 Updated by intrigeri 2017-05-19 16:55:59

On https://jenkins.tails.boum.org/job/test_Tails_ISO_feature-12485-tor-0.3.x/1/ only some USB (Bug #12565, orthogonal to this ticket) and OpenPGP online tests failed. I’ll re-run the OpenPGP ones locally before sending to QA.

#5 Updated by intrigeri 2017-05-19 19:07:52

  • Assignee changed from intrigeri to anonym
  • QA Check set to Ready for QA

I’ve seen the same OpenPGP tests fail on a feature/stretch -based branch (with Tor 0.2.9) as well so I suspect it’s unrelated: maybe the hidden service is having problems. I’ve run locally: features/torified_gnupg.feature (one single failure), features/tor_bridges.feature, features/tor_enforcement.feature, features/tor_stream_isolation.feature (no failure). I’ll keep an eye on https://jenkins.tails.boum.org/job/test_Tails_ISO_feature-12485-tor-0.3.x/2/console but if you’re bold you can already review’n’merge this.

#6 Updated by intrigeri 2017-05-19 19:12:54

  • Assignee changed from anonym to intrigeri
  • QA Check changed from Ready for QA to Dev Needed

I’ve also run features/time_syncing.feature:15 locally (it is fragile; everything else in this feature has passed on https://jenkins.tails.boum.org/job/test_Tails_ISO_feature-12485-tor-0.3.x/2/console). It fails with a notification that says “Could not fetch Tor consensus”; maybe that’s why it’s flagged as fragile? I’ll test it by hand.

#7 Updated by intrigeri 2017-05-19 19:36:10

intrigeri wrote:
> I’ve also run features/time_syncing.feature:15 locally (it is fragile; everything else in this feature has passed on https://jenkins.tails.boum.org/job/test_Tails_ISO_feature-12485-tor-0.3.x/2/console). It fails with a notification that says “Could not fetch Tor consensus”; maybe that’s why it’s flagged as fragile? I’ll test it by hand.

Testing by hand, I see weird behavior again (possibly some of my bridges are down, not tested them recently) but in the end Tor becomes usable although the time sync failed. Then I turned off and on the network connection and the tor service failed to restart (could not read torrc); that’s a bug I’ve reported earlier today (https://bugs.debian.org/862993); the workaround I’ve documented there works so I’ll apply it on the topic branch.

#8 Updated by intrigeri 2017-05-19 19:45:10

  • Assignee changed from intrigeri to anonym
  • QA Check changed from Dev Needed to Ready for QA

Workaround applied, hopefully there’s no other issue that our test suite didn’t notice. Please merge if https://jenkins.tails.boum.org/job/build_Tails_ISO_feature-12485-tor-0.3.x/7/console succeeds (I don’t see how making the AppArmor profile more relaxed can break anything so I won’t run more tests).

#10 Updated by anonym 2017-05-20 08:15:58

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

#11 Updated by intrigeri 2017-05-23 09:06:05

  • Status changed from Fix committed to Resolved