Bug #12461

Test suite fails to enable persistence in "Persistent browser bookmarks"

Added by intrigeri 2017-04-19 15:28:24 . Updated 2020-04-15 06:02:08 .

Status:
In Progress
Priority:
Normal
Assignee:
anonym
Category:
Test suite
Target version:
Start date:
2017-04-19
Due date:
% Done:

10%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Welcome Screen
Deliverable for:

Description

  <a class='issue tracker-1 status-9 priority-4 priority-default child' href='/code/issues/11585' title='&#34;Persistent browser bookmarks&#34; is fragile'>Bug #11585</a>
  @fragile
  Scenario: Persistent browser bookmarks                                                                          # features/torified_browsing.feature:155
    Given I have started Tails without network from a USB drive with a persistent partition enabled and logged in # features/step_definitions/snapshots.rb:172
    And all persistence presets are enabled                                                                       # features/step_definitions/usb.rb:365
    And all persistent filesystems have safe access rights                                                        # features/step_definitions/usb.rb:470
    And all persistence configuration files have safe access rights                                               # features/step_definitions/usb.rb:481
    And all persistent directories have safe access rights                                                        # features/step_definitions/usb.rb:500
    When I start the Tor Browser in offline mode                                                                  # features/step_definitions/common_steps.rb:376
    And I add a bookmark to eff.org in the Tor Browser                                                            # features/step_definitions/common_steps.rb:418
    And I warm reboot the computer                                                                                # features/step_definitions/common_steps.rb:554
    And the computer reboots Tails                                                                                # features/step_definitions/common_steps.rb:259
    And I enable persistence                                                                                      # features/step_definitions/usb.rb:352
      FindFailed: can not find TailsGreeterPersistencePassphrase.png in S(0)[0,0 1024x768]
        Line 2171, in file Region.java
       (RuntimeError)
      features/torified_browsing.feature:165:in `And I enable persistence'

I see 4 chars already in the persistence passphrase field which explains the resulting behavior. Never seen that outside of the test suite. Seen that on feature/stretch and Feature #5630. Interestingly, I’ve never seen this happen in other scenarios that use persistence, which might help identify the root cause :)


Subtasks


Related issues

Related to Tails - Bug #17125: "Persistent browser bookmarks" test suite scenario regression Resolved

History

#1 Updated by intrigeri 2017-05-18 11:29:33

-  @screen.wait_and_click('TailsGreeterPersistencePassphrase.png', 10)
+  sleep 5 # Give the Greeter some more time to be ready
+  @screen.type("p", Sikuli::KeyModifier.ALT)

Might be enough. Untested.

#2 Updated by intrigeri 2017-05-22 06:47:03

  • Target version changed from Tails_3.0~rc1 to Tails_3.0

#3 Updated by intrigeri 2017-05-31 12:02:46

  • Assignee changed from anonym to intrigeri

This bug prevents me from automatically testing the branch for Bug #12568 so I’ll give it a try (and will give up if a trivial workaround isn’t enough).

#4 Updated by intrigeri 2017-05-31 13:01:59

I’ve tried a few workarounds and none of their effects makes any sense to me. It really looks like Sikuli’s keyboard interaction in a very weird state during “I enable persistence” in this scenario. So I’m giving up and will have to test Bug #12568 manually.

#5 Updated by intrigeri 2017-05-31 13:03:48

  • Assignee changed from intrigeri to anonym

#6 Updated by intrigeri 2017-05-31 14:16:34

I strongly suspect that we’re hit by the QXL “graphics buffers from previous boot strike again” issue, and try to interact with a Greeter that’s not there yet, but is merely a picture of something that happens during the previous boot.

#7 Updated by anonym 2017-06-12 16:07:23

  • Target version changed from Tails_3.0 to Tails_3.1

#8 Updated by anonym 2017-06-29 13:32:44

  • blocks Feature #13239: Core work 2017Q3: Test suite maintenance added

#9 Updated by anonym 2017-07-06 14:15:06

  • Target version changed from Tails_3.1 to Tails_3.2

#10 Updated by intrigeri 2017-09-07 06:35:27

  • Target version changed from Tails_3.2 to Tails_3.3

#11 Updated by intrigeri 2017-10-01 09:57:08

  • blocks Feature #13240: Core work 2017Q4: Test suite maintenance added

#12 Updated by intrigeri 2017-10-01 09:57:09

  • blocked by deleted (Feature #13239: Core work 2017Q3: Test suite maintenance)

#13 Updated by intrigeri 2017-11-10 14:16:32

  • Target version changed from Tails_3.3 to Tails_3.5

#14 Updated by intrigeri 2017-12-07 12:44:18

  • Target version deleted (Tails_3.5)

#15 Updated by intrigeri 2018-01-01 16:57:17

  • blocked by deleted (Feature #13240: Core work 2017Q4: Test suite maintenance)

#16 Updated by intrigeri 2018-08-17 07:46:21

intrigeri wrote:
> I strongly suspect that we’re hit by the QXL “graphics buffers from previous boot strike again” issue, and try to interact with a Greeter that’s not there yet, but is merely a picture of something that happens during the previous boot.

I’ve seen it again and here’s what happens:

  1. Tails boots and eventually the Greeter appears, with 4 chars already typed in the persistence passphrase field; I think that might be a QXL problem. This makes “the computer reboots Tails” pass so the test suite starts looking for TailsGreeterPersistencePassphrase.png
  2. The screen goes black for a while.
  3. I see the fade in via grey to a new Greeter which does have the expected TailsGreeterPersistencePassphrase.png

Between step 1 and step 3, about 30 seconds have passed so @screen.wait_and_click('TailsGreeterPersistencePassphrase.png', 10) has timeout’ed for a while already, hence the test failure. I’ll bump this timeout.

#17 Updated by intrigeri 2018-08-17 07:49:15

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

> I’ll bump this timeout.

That’s commit:0e2e266343547c9657d562325444f0a4f59f550f, pushed straight to stable (I can’t push to testing right now because it’s currently at the 3.9-rc1 tag, and it would be sad to have this only on the devel branch for months).

#18 Updated by intrigeri 2019-10-06 05:24:54

  • related to Bug #17125: "Persistent browser bookmarks" test suite scenario regression added

#19 Updated by intrigeri 2020-04-15 06:02:08

  • Affected tool changed from Greeter to Welcome Screen