Bug #12405

DAVE: bump the mirrors.json size limit

Added by intrigeri 2017-03-28 13:09:16 . Updated 2018-03-14 11:09:24 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Installation
Target version:
Start date:
2017-03-28
Due date:
% Done:

100%

Feature Branch:
mirror-pool-dispatcher:bugfix/11735-mirror-pool-size
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Verification Extension
Deliverable for:

Description

As seen on Bug #11735#note-13 the size limit is too low. This problem was temporarily workaround’ed, but it’ll come up again. mirror-pool-dispatcher:bugfix/11735-mirror-pool-size fixes this. Once this is merged we need a new DAVE release with the embedded copy of m-p-d updated.


Subtasks


Related issues

Blocked by Tails - Bug #11735: Tails-Upgrader "cannot choose a download server" Resolved 2016-08-26

History

#1 Updated by intrigeri 2017-03-28 13:09:27

  • blocked by Bug #11735: Tails-Upgrader "cannot choose a download server" added

#2 Updated by anonym 2017-04-05 12:35:59

  • Status changed from Confirmed to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 0 to 100
  • QA Check set to Pass

Forgot to close this one when closing Bug #11735.

#3 Updated by anonym 2017-04-19 17:26:09

  • Status changed from Fix committed to Resolved

#4 Updated by intrigeri 2017-04-20 05:55:08

  • Status changed from Resolved to Confirmed
  • Assignee set to anonym
  • Target version changed from Tails_2.12 to Tails_3.0~rc1
  • % Done changed from 100 to 0
  • QA Check deleted (Pass)

Wait, was a new DAVE released?

#5 Updated by anonym 2017-04-20 09:17:59

intrigeri wrote:
> Wait, was a new DAVE released?

Nope! Note that I have no idea of how these things are connected yet and apparently I was too hasty on this one. Sorry!

#6 Updated by intrigeri 2017-05-16 16:23:02

  • Priority changed from Normal to Elevated
  • Target version changed from Tails_3.0~rc1 to Tails_3.0

#7 Updated by anonym 2017-06-12 16:07:23

  • Target version changed from Tails_3.0 to Tails_3.1

#8 Updated by anonym 2017-07-06 14:15:06

  • Target version changed from Tails_3.1 to Tails_3.2

#9 Updated by intrigeri 2017-09-07 08:24:56

  • Target version changed from Tails_3.2 to Tails_3.3

I suggest you ignore DAVE until the 3.2 release and then put it on your list of top priorities for the 3.3 cycle.

#10 Updated by intrigeri 2017-11-06 15:32:43

  • Target version changed from Tails_3.3 to Tails_3.5

(making anonym’s plate lighter; this can wait a bit more)

#11 Updated by intrigeri 2017-11-18 10:54:45

  • Affected tool changed from Download and Verification Extension to Verification Extension

#12 Updated by anonym 2017-12-14 14:37:52

  • Assignee changed from anonym to sajolida

#13 Updated by sajolida 2018-01-15 16:09:12

#14 Updated by Anonymous 2018-01-16 08:33:32

intrigeri wrote:
> As seen on Bug #11735#note-13 the size limit is too low. This problem was temporarily workaround’ed, but it’ll come up again. mirror-pool-dispatcher:bugfix/11735-mirror-pool-size fixes this. Once this is merged we need a new DAVE release with the embedded copy of m-p-d updated.

The new DAVE does not use an embedded copy of the mirror-pool-dispatcher anymore as far as I know.
Thus, it would be sufficient to merge this change and push it to our website, which the new extension relies upon. Has somebody reviewed this code? If not, let’s try to assign this ticket to somebody who can review it? Foundations Team?

#15 Updated by intrigeri 2018-01-16 11:09:24

  • Assignee deleted (sajolida)

> Thus, it would be sufficient to merge this change and push it to our website, which the new extension relies upon.

ACK

> Has somebody reviewed this code? If not, let’s try to assign this ticket to somebody who can review it? Foundations Team?

I think you’re the best person to review this (tiny) change to code we wrote together; worst case my FT team-mate could do it but I doubt he knows this codebase.

FWIW the proposed branch merely bumps a hard-coded “8” to “32”. The commit message is longer than the diff :)

#16 Updated by Anonymous 2018-01-16 11:17:28

  • QA Check set to Ready for QA

ack! I’ll do the review then.

#17 Updated by sajolida 2018-01-17 18:52:23

#18 Updated by Anonymous 2018-01-22 17:14:37

  • Status changed from Confirmed to Resolved
  • QA Check changed from Ready for QA to Pass

This change was already merged by anonym.

#19 Updated by intrigeri 2018-01-23 09:38:17

  • Status changed from Resolved to In Progress
  • Target version changed from Tails_3.5 to Tails_3.6
  • % Done changed from 0 to 80

u wrote:
> This change was already merged by anonym.

Alas, it’s a tad more complicated than that. anonym did merge this branch into the public mirror for m-p-d (tails@git.tails.boum.org:mirror-pool-dispatcher.git) on April 3 last year, but that’s mostly a no-op and will be overwritten next time someone pushes changes to the master repo (boum_org_amnesia@webmasters.boum.org:mirror-pool-dispatcher.git). To make these changes effective we also need to:

  1. push the changes to the master repo so the change is deployed on our website
  2. in tails.git, update the corresponding submodule so the change is used by Tails Upgrader

If you prefer I can handle this.

#20 Updated by Anonymous 2018-01-23 09:53:38

  • Assignee set to intrigeri

intrigeri wrote:
> u wrote:
> > This change was already merged by anonym.
>
> Alas, it’s a tad more complicated than that. anonym did merge this branch into the public mirror for m-p-d (tails@git.tails.boum.org:mirror-pool-dispatcher.git) on April 3 last year, but that’s mostly a no-op and will be overwritten next time someone pushes changes to the master repo (boum_org_amnesia@webmasters.boum.org:mirror-pool-dispatcher.git). To make these changes effective we also need to:
>
> # push the changes to the master repo so the change is deployed on our website

looks like I don’t have this set up, maybe I don’t have access to it actually.

> # in tails.git, update the corresponding submodule so the change is used by Tails Upgrader
>
> If you prefer I can handle this.

Go ahead.

#21 Updated by intrigeri 2018-01-23 11:41:14

>> # push the changes to the master repo so the change is deployed on our website

> looks like I don’t have this set up, maybe I don’t have access to it actually.

IIRC access to it comes automatically with access to the master tails.git, so I’m pretty sure you have access to it but need to add the Git remote.

>> If you prefer I can handle this.

> Go ahead.

OK!

#22 Updated by intrigeri 2018-01-23 17:48:26

  • Status changed from In Progress to Fix committed
  • % Done changed from 80 to 100

All done and pushed to devel.

#23 Updated by intrigeri 2018-01-23 17:51:40

  • Assignee deleted (intrigeri)

#24 Updated by bertagaz 2018-03-14 11:09:24

  • Status changed from Fix committed to Resolved