Feature #12348

Review'n'merge the reproducible builds branch into feature/stretch

Added by intrigeri 2017-03-15 14:19:02 . Updated 2017-05-23 09:10:16 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.0~rc1
Start date:
2017-03-15
Due date:
% Done:

100%

Feature Branch:
feature/5630-deterministic-builds
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
289

Description

Subtasks

Related issues

Blocked by Tails - Feature #11983: Check if the test suite has more failures on the reproducible ISO Resolved 2016-11-21

History

#1 Updated by intrigeri 2017-03-15 21:55:59

  • Status changed from Confirmed to In Progress
  • Assignee changed from intrigeri to anonym
  • % Done changed from 0 to 20
  • Feature Branch set to feature/5630-deterministic-builds

I’m happy with the current state of the branch at commit:bdacff0e351646086685e623ab6b32fd329cb967. Please review’n’merge into feature/stretch if happy with it too :)

#2 Updated by intrigeri 2017-03-16 05:57:41

It would probably be a good idea to have a look at Feature #11983#note-4 first though: we don’t want to break the test suite on feature/stretch right now.

#3 Updated by intrigeri 2017-03-16 12:47:50

  • blocked by Feature #11983: Check if the test suite has more failures on the reproducible ISO added

#4 Updated by intrigeri 2017-04-05 10:26:29

I would love to merge this in time for Tails 3.0~beta4, that I intend to build around April 16-17. Now, we need to take care of Feature #11983 first (and possibly adjust our isotesters’ setup accordingly). Does it sound realistic to you?

#5 Updated by anonym 2017-04-17 14:17:56

  • Assignee changed from anonym to intrigeri
  • % Done changed from 20 to 50

Code review passes! I pushed an untested commit that should repair offline mode building vs the dependency on NTP. Not sure if that breaks the use of TAILS_DATE_OFFSET in offline mode, bit I guess there was a reason for introducing NTP in the same commit?

#6 Updated by intrigeri 2017-04-17 14:26:46

> Code review passes!

:)

I might merge this into feature/stretch today or tomorrow, depending on the outcome of Feature #11983. We’ll see!

> I pushed an untested commit that should repair offline mode building vs the dependency on NTP.

Looks good.

> Not sure if that breaks the use of TAILS_DATE_OFFSET in offline mode,

I don’t think it will break it. We’ll see.

> I guess there was a reason for introducing NTP in the same commit?

Yes, when introducing stuff about the build time, I wanted to ensure that the build really happens with the expected time, i.e. the correct current time (when TAILS_DATE_OFFSET is not set) or something based on the correct current time (when TAILS_DATE_OFFSET is set), instead of “whatever time the VM believes it is” :)

#7 Updated by intrigeri 2017-05-19 11:27:02

  • Target version set to Tails_3.0~rc1

The current plan for 3.0~rc1 is to merge bugfix/11971-fontconfig-cache-in-iso, which won’t produce reproducible ISOs due to Bug #12567, but would be a great step forward.

#8 Updated by intrigeri 2017-05-19 18:09:14

  • Assignee changed from intrigeri to anonym

Please review’n’merge the branch for Feature #11971 and then mark this ticket as fix committed. We’ll use other tickets for other related stuff we want to merge in 3.0 final.

#9 Updated by anonym 2017-05-20 07:59:07

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

#10 Updated by intrigeri 2017-05-23 09:10:16

  • Status changed from Fix committed to Resolved