Bug #12270

Document how to change the password of an encrypted volume

Added by sajolida 2017-02-27 10:00:19 . Updated 2017-04-28 14:35:06 .

Status:
Resolved
Priority:
Low
Assignee:
Category:
Target version:
Start date:
2017-02-27
Due date:
% Done:

0%

Feature Branch:
doc/12270-change-password-encrypted-volume
Type of work:
End-user documentation
Blueprint:

Starter:
1
Affected tool:
Deliverable for:

Description

So far we have:

  • Create and use encrypted volumes
  • Change the passphrase of the persistent volume

But nothing to “Change the passphrase of an encrypted volume”.

Files

doc_change_passphrase_encrypted_volume.patch (2002 B) cbrownstein, 2017-02-28 07:01:08
0001-Reorder-sections.patch (2537 B) cbrownstein, 2017-04-15 01:00:08
0002-Add-network-wireless-encrypted.png.patch (1023 B) cbrownstein, 2017-04-15 01:00:22
0003-Remove-word-padlock.patch (1261 B) cbrownstein, 2017-04-15 06:45:01

Subtasks

Related issues

Blocks Tails - Feature #12432: Technical writing core work 2017Q2 Resolved 2017-04-07

History

#1 Updated by sajolida 2017-02-27 10:03:56

  • Starter set to Yes

#2 Updated by cbrownstein 2017-02-28 05:11:00

I am working on this and within 24 hours should be able to upload a patch for review.

#3 Updated by cbrownstein 2017-02-28 07:03:34

Attached: Patch for review.

The text “padlock” should be replaced with the proper glyph/icon. But, I could not find that glyph (or icon).

Help would be appreciated!

#4 Updated by intrigeri 2017-02-28 10:47:45

  • Assignee set to sajolida
  • QA Check set to Ready for QA

sajolida, do you want it or should I try to find someone else?

#5 Updated by sajolida 2017-04-07 15:15:48

#6 Updated by sajolida 2017-04-14 16:18:39

  • Status changed from Confirmed to In Progress
  • Feature Branch set to doc/12270-change-password-encrypted-volume

Hi Cody!

First of all, sorry for the huge delay. But I’ll always find time to review your work sooner or later :)

Second, thanks for the excellent patch. I created a branch with your patch and did a few very minor changes (a7bff16ab3..010d6a26c2). But it was pretty much perfect from the start! Please have a look and tell me if I can merge.

We take the icons from /usr/share/icons/HighContrast/16x16/ in Tails (or whatever GNOME you might have).

Ah, and I wondered whether we should put this section at the very end (after “Opening encrypted volumes from other operating systems”). Your new section is quite longer and probably relevant to less people than the last two ones which are also some kind of warnings. What do you think?

Also, disclaimer: I’m not a native English speaker (and you might be) so please correct me when my grammer is wrong. For example if 9a5953e39a is incorrect.

#7 Updated by sajolida 2017-04-14 16:19:32

  • Assignee changed from sajolida to cbrownstein

I also granted you the “Contributor” role on Redmine so now you can assign yourself some tickets if you want. I’m reassigning this one to you for the last review before I do the merge.

#8 Updated by cbrownstein 2017-04-15 01:00:34

Hello sajolida,

Thank you for taking the time to review my work.

I’ve reviewed your changes to the wording. The changes make the instructions easier to read. So, thank you for that also.

I agree with you, for the reasons that you’ve stated, that the new section should appear at the end of the document. I’ve made that change in the first patch I’m attaching.

The second patch I’m attaching adds the image network-wireless-encrypted.png so that the padlock displays.

For my learning: How did you find that icon? I wouldn’t think an icon appearing in a disk management utility would be named network-wireless-encrypted.png.

#9 Updated by cbrownstein 2017-04-15 06:46:21

One last patch, to remove the word “padlock.” It’s redundant and inconsistent with the rest of the document. After applying this patch, and the patches I submitted earlier, the feature branch is ready to be merged.

As an alternative to applying the patches, I’ve set up a repository from which my changes can be pulled:

https://github.com/cbrownstein/tails

#10 Updated by intrigeri 2017-04-15 07:05:03

  • Assignee changed from cbrownstein to sajolida

#11 Updated by sajolida 2017-04-28 14:16:13

> I agree with you, for the reasons that you’ve stated, that the new section should appear at the end of the document. I’ve made that change in the first patch I’m attaching.

Cool!

> The second patch I’m attaching adds the image network-wireless-encrypted.png so that the padlock displays.

Oops, I apparently forgot to add it to my branch. My bad!

> For my learning: How did you find that icon?

I found it in /usr/share/icons/HighContrast/16x16/ in Tails.

> I wouldn’t think an icon appearing in a disk management utility would be named network-wireless-encrypted.png.

What I do in such cases is browse /usr/share/icons/HighContrast/16x16/
for the icon I’m looking for and copy it to the Git repo. Sometimes the
same icon is used in different places in GNOME and so have weird names
in some context. Still, I usually keep the original name :)

> One last patch, to remove the word “padlock.”

I almost mentioned this in my previous review but then thought that I
was nitpicking too much and refrain from doing so :)

Since we’re removing the word in the text, I added it back to the alt=“”
attribute for people would don’t see the picture.

And I can merge that! Woh!

#12 Updated by sajolida 2017-04-28 14:35:06

  • Status changed from In Progress to Resolved
  • Assignee deleted (sajolida)
  • QA Check deleted (Ready for QA)